[4] Allow banner creation if there are not categories (#33399)

* add ACL check * allow adding banners from empty state if no categories
joomla · Apr 30, 2021 · 3a9ebcb · 3a9ebcb
1 parent aedf7e3
commit 3a9ebcb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/administrator/components/com_banners/src/View/Banners/HtmlView.php b/administrator/components/com_banners/src/View/Banners/HtmlView.php
@@ -149,7 +149,7 @@ protected function addToolbar(): void
 
 		ToolbarHelper::title(Text::_('COM_BANNERS_MANAGER_BANNERS'), 'bookmark banners');
 
-		if (\count($user->getAuthorisedCategories('com_banners', 'core.create')) > 0)
+		if ($canDo->get('core.create') || count($user->getAuthorisedCategories('com_banners', 'core.create')) > 0)
 		{
 			$toolbar->addNew('banner.add');
 		}

diff --git a/administrator/components/com_banners/tmpl/banners/emptystate.php b/administrator/components/com_banners/tmpl/banners/emptystate.php
@@ -19,7 +19,9 @@
 	'icon'       => 'icon-bookmark banners',
 ];
 
-if (count(Factory::getApplication()->getIdentity()->getAuthorisedCategories('com_banners', 'core.create')) > 0)
+$user = Factory::getApplication()->getIdentity();
+
+if ($user->authorise('core.create', 'com_banners') || count($user->getAuthorisedCategories('com_banners', 'core.create')) > 0)
 {
 	$displayData['createURL'] = 'index.php?option=com_banners&task=banner.add';
 }