Skip to content

Commit

Permalink
Closes #22980 - Dont hide data when not needed
Browse files Browse the repository at this point in the history
  • Loading branch information
Phil E. Taylor committed Nov 11, 2018
1 parent 316bd2f commit 3e2e281
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions administrator/language/en-GB/en-GB.plg_system_stats.ini
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ PLG_SYSTEM_STATS_MODE_OPTION_ON_DEMAND="On demand"
PLG_SYSTEM_STATS_MSG_ALLOW_SENDING_DATA="Enable Joomla Statistics?"
PLG_SYSTEM_STATS_MSG_JOOMLA_WANTS_TO_SEND_DATA="To better understand our install base and end user environments it is helpful if you send some site information back to a Joomla! controlled central server. No identifying data is captured at any point. You can change these settings later from Plugins > System - Joomla! Statistics."
PLG_SYSTEM_STATS_MSG_WHAT_DATA_WILL_BE_SENT="Select here to see the information that will be sent."
PLG_SYSTEM_STATS_MSG_THE_FOLLOWING_DATA_WILL_BE_SENT="The following information will be sent."
PLG_SYSTEM_STATS_RESET_UNIQUE_ID="Reset Unique ID"
PLG_SYSTEM_STATS_UNIQUE_ID_LABEL="Unique ID"
PLG_SYSTEM_STATS_XML_DESCRIPTION="System Plugin that sends environment statistics to a server controlled by the Joomla! project for statistical analysis. Statistics sent include PHP version, CMS version, Database type, Database version and Server type."
1 change: 0 additions & 1 deletion plugins/system/stats/layouts/field/data.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,4 @@
* @var array $statsData Statistics that will be sent to the stats server
*/
?>
<a href="#" id="js-pstats-data-details-toggler"><?php echo Text::_('PLG_SYSTEM_STATS_MSG_WHAT_DATA_WILL_BE_SENT'); ?></a>
<?php echo $field->render('stats', compact('statsData'));
3 changes: 2 additions & 1 deletion plugins/system/stats/layouts/stats.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@

$versionFields = array('php_version', 'db_version', 'cms_version');
?>
<table class="table mb-1 d-none" id="js-pstats-data-details">
<h4><?php echo Text::_('PLG_SYSTEM_STATS_MSG_THE_FOLLOWING_DATA_WILL_BE_SENT'); ?></h4>
<table class="table mb-1">
<?php foreach ($statsData as $key => $value) : ?>
<tr>
<td><strong><?php echo Text::_('PLG_SYSTEM_STATS_LABEL_' . strtoupper($key)); ?></strong></td>
Expand Down

0 comments on commit 3e2e281

Please sign in to comment.