Skip to content

Commit

Permalink
[a11y] Cache toolbar
Browse files Browse the repository at this point in the history
We use the icon name to populate the ID. This toolbar has the same icon for both buttons so we have two buttons with the same id which is an accessibility failure

This pr ensures every id attribute value is unique

Because the icon has multiple names we can simply use one of the alternative names as a quick and dirty fix.

There is no visual change
  • Loading branch information
brianteeman committed Feb 15, 2018
1 parent 5bf0e5d commit 4632914
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -76,7 +76,7 @@ protected function addToolbar()
}

JToolbarHelper::custom('delete', 'delete.png', 'delete_f2.png', 'JTOOLBAR_DELETE', true);
JToolbarHelper::custom('deleteAll', 'delete.png', 'delete_f2.png', 'JTOOLBAR_DELETE_ALL', false);
JToolbarHelper::custom('deleteAll', 'remove.png', 'delete_f2.png', 'JTOOLBAR_DELETE_ALL', false);
JToolbarHelper::divider();

if (JFactory::getUser()->authorise('core.admin', 'com_cache'))
Expand Down

0 comments on commit 4632914

Please sign in to comment.