Skip to content

Commit

Permalink
Fixed tests and implementation
Browse files Browse the repository at this point in the history
  • Loading branch information
frankmayer committed Dec 30, 2016
1 parent 0609b19 commit 5db7e53
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion libraries/cms/installer/installer.php
Original file line number Diff line number Diff line change
Expand Up @@ -2257,7 +2257,7 @@ public static function parseXMLInstallFile($path)

$data['copyright'] = (string) $xml->copyright;
$data['authorEmail'] = (string) $xml->authorEmail;
$data['authorUrl'] = (string) $xml->authorUrl;
$data['authorUrl'] = &$data['authorURL'] = (string) $xml->authorUrl;
$data['version'] = (string) $xml->version;
$data['description'] = (string) $xml->description;
$data['group'] = (string) $xml->group;
Expand Down
12 changes: 6 additions & 6 deletions tests/unit/suites/libraries/cms/installer/JInstallerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -286,8 +286,8 @@ public function testParseOldXMLInstallFile()

// Verify that an old style element name is still usable
$this->assertEquals(
$xml['packagename'],
'joomla',
$xml['authorUrl'],
'https://www.joomla.org',
'The package name string should be "joomla" as specified in the parsed XML file'
);
}
Expand Down Expand Up @@ -319,15 +319,15 @@ public function testParseNewXMLInstallFile()

// Verify that an old style element name is still usable
$this->assertEquals(
$xml['packagename'],
'joomla',
$xml['authorUrl'],
'https://www.joomla.org',
'The old package name string should be "joomla" as specified in the parsed XML file'
);

// Verify that an old style element name is still usable
$this->assertEquals(
$xml['packageName'],
'joomla',
$xml['authorURL'],
'https://www.joomla.org',
'The new package name string should be "joomla" as specified in the parsed XML file'
);
}
Expand Down

0 comments on commit 5db7e53

Please sign in to comment.