Support for attribute maxlength. Form field textarea. Issue #6459

Issue #6459

The maxlength attribute specifies the maximum length (in characters) of a text area. The maxlength attribute is new for the <textarea> tag in HTML5.

Test:

- Edit /administrator/components/com_config/model/form/application.xml
- Add attribute
maxlength="25"
to field MetaDesc (or any other field of type textarea).
- Go to administrator/index.php?option=com_config > Site
- Enter text into field "Site Meta Description".
- No limitation concerning length.
- Apply patch. Try again. 25 characters maximum are possible.

libraries/joomla/form/fields/textarea.php

@@ -57,6 +57,7 @@ public function __get($name)
 		{
 			case 'rows':
 			case 'columns':
+			case 'maxlength':
 				return $this->$name;
 		}
 
@@ -79,6 +80,7 @@ public function __set($name, $value)
 		{
 			case 'rows':
 			case 'columns':
+			case 'maxlength':
 				$this->$name = (int) $value;
 				break;
 
@@ -107,8 +109,9 @@ public function setup(SimpleXMLElement $element, $value, $group = null)
 
 		if ($return)
 		{
-			$this->rows    = isset($this->element['rows']) ? (int) $this->element['rows'] : false;
-			$this->columns = isset($this->element['cols']) ? (int) $this->element['cols'] : false;
+			$this->rows      = isset($this->element['rows']) ? (int) $this->element['rows'] : false;
+			$this->columns   = isset($this->element['cols']) ? (int) $this->element['cols'] : false;
+			$this->maxlength = isset($this->element['maxlength']) ? (int) $this->element['maxlength'] : false;
 		}
 
 		return $return;
@@ -139,6 +142,7 @@ protected function getInput()
 		$autocomplete = $autocomplete == ' autocomplete="on"' ? '' : $autocomplete;
 		$autofocus    = $this->autofocus ? ' autofocus' : '';
 		$spellcheck   = $this->spellcheck ? '' : ' spellcheck="false"';
+		$maxlength    = $this->maxlength ? ' maxlength="' . $this->maxlength . '"' : '';
 
 		// Initialize JavaScript field attributes.
 		$onchange = $this->onchange ? ' onchange="' . $this->onchange . '"' : '';
@@ -149,7 +153,7 @@ protected function getInput()
 		JHtml::_('script', 'system/html5fallback.js', false, true);
 
 		return '<textarea name="' . $this->name . '" id="' . $this->id . '"' . $columns . $rows . $class
-			. $hint . $disabled . $readonly . $onchange . $onclick . $required . $autocomplete . $autofocus . $spellcheck . ' >'
+			. $hint . $disabled . $readonly . $onchange . $onclick . $required . $autocomplete . $autofocus . $spellcheck . $maxlength . ' >'
 			. htmlspecialchars($this->value, ENT_COMPAT, 'UTF-8') . '</textarea>';
 	}
 }