Simplify conditional

joomla · Aug 21, 2016 · 841245f · 841245f
1 parent 1eed385
commit 841245f
Showing 1 changed file with 10 additions and 16 deletions.
diff --git a/administrator/components/com_menus/models/fields/modal/menu.php b/administrator/components/com_menus/models/fields/modal/menu.php
@@ -91,16 +91,13 @@ protected function getInput()
 			{
 				$clearField = JText::_('COM_MENUS_SELECT_A_MENUITEM', true);
 			}
+			elseif ((string) $this->element->option['value'] == '')
+			{
+				$clearField =  JText::_($this->element->option, true);
+			}
 			else
 			{
-				if ((string) $this->element->option['value'] == '')
-				{
-					$clearField =  JText::_($this->element->option, true);
-				}
-				else
-				{
-					$clearField = JText::_('JDEFAULT', true);
-				}
+				$clearField = JText::_('JDEFAULT', true);
 			}
 
 			$clearField = htmlspecialchars($clearField, ENT_QUOTES, 'UTF-8');
@@ -169,16 +166,13 @@ protected function getInput()
 			{
 				$title = JText::_('COM_MENUS_SELECT_A_MENUITEM', true);
 			}
+			elseif ((string) $this->element->option['value'] == '')
+			{
+				$title = JText::_($this->element->option, true);
+			}
 			else
 			{
-				if ((string) $this->element->option['value'] == '')
-				{
-					$title = JText::_($this->element->option, true);
-				}
-				else
-				{
-					$title = JText::_('JDEFAULT');
-				}
+				$title = JText::_('JDEFAULT');
 			}
 		}