Reverted some changes, as they are in included external frameworks

joomla · Sep 25, 2016 · 8a973a8 · 8a973a8
1 parent 6c2d7cd
commit 8a973a8
Show file tree

Hide file tree

Showing 9 changed files with 11 additions and 11 deletions.
diff --git a/libraries/fof/database/driver/pdo.php b/libraries/fof/database/driver/pdo.php
@@ -1047,7 +1047,7 @@ public function __sleep()
 			// Do not serialize properties that are PDO
 			if ($property->isStatic() == false && !($this->{$property->name} instanceof PDO))
 			{
-				$serializedProperties[] = $property->name;
+				array_push($serializedProperties, $property->name);
 			}
 		}
 

diff --git a/libraries/fof/encrypt/randval.php b/libraries/fof/encrypt/randval.php
@@ -112,7 +112,7 @@ public function genRandomBytes($length = 32)
 			 * Collect any entropy available from the PHP system and filesystem.
 			 * If we have ssl data that isn't strong, we use it once.
 			 */
-			$entropy = mt_rand() . uniqid(mt_rand(), true) . $sslStr;
+			$entropy = rand() . uniqid(mt_rand(), true) . $sslStr;
 			$entropy .= implode('', @fstat(fopen(__FILE__, 'r')));
 			$entropy .= memory_get_usage();
 			$sslStr = '';

diff --git a/libraries/fof/encrypt/totp.php b/libraries/fof/encrypt/totp.php
@@ -171,7 +171,7 @@ public function generateSecret()
 
 		for ($i = 1; $i <= $this->_secretLength; $i++)
 		{
-			$c = mt_rand(0, 255);
+			$c = rand(0, 255);
 			$secret .= pack("c", $c);
 		}
 		$base32 = new FOFEncryptBase32;

diff --git a/libraries/fof/hal/render/json.php b/libraries/fof/hal/render/json.php
@@ -80,7 +80,7 @@ public function render($options = array())
 
 				foreach ($links as $link)
 				{
-					$serialiseThis->_links->$rel[] = $this->_getLink($link);
+					array_push($serialiseThis->_links->$rel, $this->_getLink($link));
 				}
 			}
 		}
@@ -102,8 +102,8 @@ public function render($options = array())
 
 				foreach ($embeddeddocs as $embedded)
 				{
-					$renderer                         = new FOFHalRenderJson($embedded);
-					$serialiseThis->_embedded->$rel[] = $renderer->render($options);
+					$renderer = new FOFHalRenderJson($embedded);
+					array_push($serialiseThis->_embedded->$rel, $renderer->render($options));
 				}
 			}
 		}

diff --git a/libraries/fof/utils/object/object.php b/libraries/fof/utils/object/object.php
@@ -197,6 +197,6 @@ public function setProperties($properties)
      */
     public function setError($error)
     {
-        $this->_errors[] = $error;
+        array_push($this->_errors, $error);
     }
 }
diff --git a/libraries/vendor/joomla/application/src/AbstractWebApplication.php b/libraries/vendor/joomla/application/src/AbstractWebApplication.php
@@ -523,7 +523,7 @@ public function prependBody($content)
 	 */
 	public function appendBody($content)
 	{
-		$this->response->body[] = (string) $content;
+		array_push($this->response->body, (string) $content);
 
 		return $this;
 	}

diff --git a/libraries/vendor/joomla/registry/src/Registry.php b/libraries/vendor/joomla/registry/src/Registry.php
@@ -617,7 +617,7 @@ public function append($path, $value)
 				$node = get_object_vars($node);
 			}
 
-			$node[] = $value;
+			array_push($node, $value);
 			$result = $value;
 		}
 

diff --git a/libraries/vendor/joomla/session/Joomla/Session/Session.php b/libraries/vendor/joomla/session/Joomla/Session/Session.php
@@ -844,7 +844,7 @@ protected function createToken($length = 32)
 
 		for ($i = 0; $i < $length; ++$i)
 		{
-			$token .= $chars[(mt_rand(0, $max))];
+			$token .= $chars[(rand(0, $max))];
 		}
 
 		return md5($token . $name);

diff --git a/libraries/vendor/joomla/string/src/Inflector.php b/libraries/vendor/joomla/string/src/Inflector.php
@@ -142,7 +142,7 @@ private function addRule($data, $ruleType)
 		foreach ($data as $rule)
 		{
 			// Ensure a string is pushed.
-			$this->rules[$ruleType][] = (string) $rule;
+			array_push($this->rules[$ruleType], (string) $rule);
 		}
 	}