Delete unnecesary catslug query from mod_related_items (#8946)

* Delete unnecesary catslug from mod_related_items * remove whitespace * catslug depricated note * start comment with a capital letter * add blank line * Update helper.php * Update helper.php
joomla · Nov 13, 2016 · 90d218b · 90d218b
1 parent af98a75
commit 90d218b
Showing 1 changed file with 3 additions and 9 deletions.
diff --git a/modules/mod_related_items/helper.php b/modules/mod_related_items/helper.php
@@ -117,15 +117,7 @@ public static function getList(&$params)
 				$case_when .= $query->concatenate(array($a_id, 'a.alias'), ':');
 				$case_when .= ' ELSE ';
 				$case_when .= $a_id . ' END as slug';
-				$query->select($case_when);
 
-				$case_when = ' CASE WHEN ';
-				$case_when .= $query->charLength('cc.alias', '!=', '0');
-				$case_when .= ' THEN ';
-				$c_id = $query->castAsChar('cc.id');
-				$case_when .= $query->concatenate(array($c_id, 'cc.alias'), ':');
-				$case_when .= ' ELSE ';
-				$case_when .= $c_id . ' END as catslug';
 				$query->select($case_when)
 					->from('#__content AS a')
 					->join('LEFT', '#__content_frontpage AS f ON f.content_id = a.id')
@@ -188,9 +180,11 @@ public static function getList(&$params)
 			foreach ($related as &$item)
 			{
 				$item->slug    = $item->id . ':' . $item->alias;
+
+				/** @deprecated Catslug is deprecated, use catid instead. 4.0 **/
 				$item->catslug = $item->catid . ':' . $item->category_alias;
 
-				$item->route = JRoute::_(ContentHelperRoute::getArticleRoute($item->slug, $item->catid, $item->language));
+				$item->route   = JRoute::_(ContentHelperRoute::getArticleRoute($item->slug, $item->catid, $item->language));
 			}
 		}