Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Brian Teeman <brian@teeman.net>
  • Loading branch information
Fedik and brianteeman committed Oct 26, 2023
1 parent fca1def commit 9644599
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion administrator/language/en-GB/tpl_atum.ini
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
ATUM="Atum Administrator template"
TPL_ATUM_BACK_TO_CONTROL_PANEL="Back to Dashboard"
TPL_ATUM_BACKEND_LOGIN="Joomla Administrator Login"
TPL_ATUM_COLORSCHEME_LABEL="Dark mode"
TPL_ATUM_COLORSCHEME_LABEL="Dark Mode"
TPL_ATUM_COLORSCHEME_OPTION_DARK="Use Dark theme"
TPL_ATUM_COLORSCHEME_OPTION_FOLLOW_OS="Follow OS settings"
TPL_ATUM_COLORSCHEME_OPTION_LIGHT="Use Light theme"
Expand Down
2 changes: 1 addition & 1 deletion administrator/templates/atum/templateDetails.xml
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
type="list"
label="TPL_ATUM_COLORSCHEME_LABEL"
default="0"
>
>
<option value="0">TPL_ATUM_COLORSCHEME_OPTION_FOLLOW_OS</option>
<option value="light">TPL_ATUM_COLORSCHEME_OPTION_LIGHT</option>
<option value="dark">TPL_ATUM_COLORSCHEME_OPTION_DARK</option>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ function dartModeWatch() {
docEl.dataset.bsTheme = newScheme;
docEl.dataset.colorScheme = newScheme;
expires.setTime(expires.getTime() + 31536000000);
// Store theme in cookies, so php will know the last choose
// Store theme in cookies, so php will know the last choice
document.cookie = `atumColorScheme=${newScheme}; expires=${expires.toUTCString()};`;
document.dispatchEvent(new CustomEvent('joomla:color-scheme-change', { bubbles: true }));
};
Expand Down

0 comments on commit 9644599

Please sign in to comment.