Skip to content

Commit

Permalink
Fix several TODOs in code
Browse files Browse the repository at this point in the history
  • Loading branch information
wilsonge committed Dec 6, 2018
1 parent 8caf7e9 commit be52cb0
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 7 deletions.
2 changes: 1 addition & 1 deletion libraries/src/Filesystem/FilesystemHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class FilesystemHelper
/**
* Remote file size function for streams that don't support it
*
* @param string $url TODO Add text
* @param string $url Link identifier
*
* @return mixed
*
Expand Down
6 changes: 1 addition & 5 deletions libraries/src/Pagination/Pagination.php
Original file line number Diff line number Diff line change
Expand Up @@ -737,11 +737,7 @@ protected function _buildDataObject()

if ($this->pagesCurrent > 1)
{
$page = ($this->pagesCurrent - 2) * $this->limit;

// Set the empty for removal from route
// @todo remove code: $page = $page == 0 ? '' : $page;

$page = ($this->pagesCurrent - 2) * $this->limit;
$data->start->base = '0';
$data->start->link = Route::_($params . '&' . $this->prefix . 'limitstart=0');
$data->previous->base = $page;
Expand Down
1 change: 0 additions & 1 deletion libraries/src/Updater/Adapter/ExtensionAdapter.php
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ protected function _endElement($parser, $name)
{
array_pop($this->stack);

// @todo remove code: echo 'Closing: '. $name .'<br>';
switch ($name)
{
case 'UPDATE':
Expand Down

0 comments on commit be52cb0

Please sign in to comment.