sendtestmail.js code refactor (#10953)

* Modified sendtestmail to be testable

* Fixed missing callback function pass

* Fixed $ = jQuery

* Modified minified version

media/system/js/sendtestmail-uncompressed.js

@@ -7,45 +7,49 @@
 /**
  * Calls the sending process of the config class
  */
-jQuery(document).ready(function ($)
+var sendTestMail = function ()
 {
-	$('#sendtestmail').click(function ()
-	{
-		var email_data = {
-			smtpauth  : $('input[name="jform[smtpauth]"]:checked').val(),
-			smtpuser  : $('input[name="jform[smtpuser]"]').val(),
-			smtppass  : $('input[name="jform[smtppass]"]').val(),
-			smtphost  : $('input[name="jform[smtphost]"]').val(),
-			smtpsecure: $('select[name="jform[smtpsecure]"]').val(),
-			smtpport  : $('input[name="jform[smtpport]"]').val(),
-			mailfrom  : $('input[name="jform[mailfrom]"]').val(),
-			fromname  : $('input[name="jform[fromname]"]').val(),
-			mailer    : $('select[name="jform[mailer]"]').val(),
-			mailonline: $('input[name="jform[mailonline]"]:checked').val()
-		};
+	$ = jQuery;
 
-		// Remove js messages, if they exist.
-		Joomla.removeMessages();
+	var email_data = {
+		smtpauth  : $('input[name="jform[smtpauth]"]:checked').val(),
+		smtpuser  : $('input[name="jform[smtpuser]"]').val(),
+		smtppass  : $('input[name="jform[smtppass]"]').val(),
+		smtphost  : $('input[name="jform[smtphost]"]').val(),
+		smtpsecure: $('select[name="jform[smtpsecure]"]').val(),
+		smtpport  : $('input[name="jform[smtpport]"]').val(),
+		mailfrom  : $('input[name="jform[mailfrom]"]').val(),
+		fromname  : $('input[name="jform[fromname]"]').val(),
+		mailer    : $('select[name="jform[mailer]"]').val(),
+		mailonline: $('input[name="jform[mailonline]"]:checked').val()
+	};
 
-		$.ajax({
-			method: "POST",
-			url: document.getElementById('sendtestmail').getAttribute('data-ajaxuri'),
-			data: email_data,
-			dataType: "json"
-		})
-		.fail(function (jqXHR, textStatus, error) {
-			Joomla.renderMessages(Joomla.ajaxErrorsMessages(jqXHR, textStatus, error));
+	// Remove js messages, if they exist.
+	Joomla.removeMessages();
 
-			window.scrollTo(0, 0);
-		})
-		.done(function (response) {
-			// Render messages, if any.
-			if (typeof response.messages == 'object' && response.messages !== null)
-			{
-				Joomla.renderMessages(response.messages);
+	$.ajax({
+		method: "POST",
+		url: document.getElementById('sendtestmail').getAttribute('data-ajaxuri'),
+		data: email_data,
+		dataType: "json"
+	})
+	.fail(function (jqXHR, textStatus, error) {
+		Joomla.renderMessages(Joomla.ajaxErrorsMessages(jqXHR, textStatus, error));
 
-				window.scrollTo(0, 0);
-			}
-		});
+		window.scrollTo(0, 0);
+	})
+	.done(function (response) {
+		// Render messages, if any.
+		if (typeof response.messages == 'object' && response.messages !== null)
+		{
+			Joomla.renderMessages(response.messages);
+
+			window.scrollTo(0, 0);
+		}
 	});
+};
+
+jQuery(document).ready(function ($)
+{
+	$('#sendtestmail').click(sendTestMail);
 });