[4.4] json_decode of NULL in InstallerScript::getItemArray() (#40527)

* json_decode of NULL * Check for name in Installer Script
joomla · Dec 7, 2023 · c4260cb · c4260cb
1 parent 90f70c1
commit c4260cb
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/libraries/src/Installer/InstallerScript.php b/libraries/src/Installer/InstallerScript.php
@@ -141,7 +141,7 @@ public function preflight($type, $parent)
 
         // Abort if the extension being installed is not newer than the currently installed version
         if (!$this->allowDowngrades && strtolower($type) === 'update') {
-            $manifest = $this->getItemArray('manifest_cache', '#__extensions', 'element', $this->extension);
+            $manifest = $this->getItemArray('manifest_cache', '#__extensions', 'name', $this->extension);
 
             // Check whether we have an old release installed and skip this check when this here is the initial install.
             if (!isset($manifest['version'])) {
@@ -301,7 +301,9 @@ public function getItemArray($element, $table, $column, $identifier)
         $db->setQuery($query);
 
         // Load the single cell and json_decode data
-        return json_decode($db->loadResult(), true);
+        $result = $db->loadResult();
+
+        return $result === null ? [] : json_decode($result, true);
     }
 
     /**