Skip to content

Commit

Permalink
[4][CloudFlare Issues] Remove validation of the session by IP address (
Browse files Browse the repository at this point in the history
…#35509)

> IMHO the commend of @arnepluhar in #35509 should also count as a successful test. He did it as a GitHub code review. The rules about what constitutes a valid test should expand to GitHub code reviews; these didn't even exist when the rules were decided upon back in the day and they make FAR MORE SENSE than comments filed on a PR!

Github is configured to allow maintainers merge only if all tests are successful.

Thanks all.
  • Loading branch information
Phil E. Taylor committed Sep 24, 2021
1 parent ebad54c commit e198c08
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions libraries/src/Service/Provider/Session.php
Expand Up @@ -35,8 +35,6 @@
use Joomla\Session\SessionInterface;
use Joomla\Session\Storage\RuntimeStorage;
use Joomla\Session\StorageInterface;
use Joomla\Session\Validator\AddressValidator;
use Joomla\Session\Validator\ForwardedValidator;

/**
* Service provider for the application's session dependency
Expand Down Expand Up @@ -329,8 +327,6 @@ private function buildSession(
}

$session = new \Joomla\CMS\Session\Session($storage, $dispatcher, $options);
$session->addValidator(new AddressValidator($input, $session));
$session->addValidator(new ForwardedValidator($input, $session));

return $session;
}
Expand Down

0 comments on commit e198c08

Please sign in to comment.