Fix not converted parameter in route::_ and log warning

joomla · Jun 16, 2019 · f1b03bb · f1b03bb
1 parent 2c5607e
commit f1b03bb
Showing 1 changed file with 3 additions and 10 deletions.
diff --git a/libraries/src/Router/Route.php b/libraries/src/Router/Route.php
@@ -75,23 +75,16 @@ public static function _($url, $xhtml = true, $tls = self::TLS_IGNORE, $absolute
 				$tls = self::TLS_DISABLE;
 			}
 
-			// @deprecated  4.0 Before 3.9.7 this method silently converted boolean to integer
-			if (is_bool($tls))
+			// @deprecated  4.0 Before 3.9.7 this method silently converted $tls to integer
+			if (!is_int($tls))
 			{
 				Log::add(
 					__METHOD__ . '() called with incompatible variable type boolean on parameter $tls.',
 					Log::WARNING,
 					'deprecated'
 				);
 
-				if ($tls === true)
-				{
-					$tls = self::TLS_FORCE;
-				}
-				else
-				{
-					$tls = self::TLS_IGNORE;
-				}
+				$tls = (int) $tls;
 			}
 
 			$app    = Factory::getApplication();