Skip to content

Commit

Permalink
Merge branch '4.3-dev' into inclusive-naming-2
Browse files Browse the repository at this point in the history
  • Loading branch information
Quy committed Jun 25, 2023
2 parents 60cc996 + a8be6ef commit f8578a4
Show file tree
Hide file tree
Showing 19 changed files with 22 additions and 22 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@
// phpcs:enable PSR1.Files.SideEffects

/**
* ComponentDispatcher class for com_admin
* ComponentDispatcher class for com_actionlogs
*
* @since 4.2.7
*/
class Dispatcher extends ComponentDispatcher
{
/**
* com_admin does not require check permission, so we override checkAccess method and have it empty
* Method to check component access permission
*
* @return void
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
// phpcs:enable PSR1.Files.SideEffects

/**
* Field to load a list of all users that have logged actions
* Field to load a list of all extensions that have logged actions
*
* @since 3.9.0
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public function download()
$message = null;
$messageType = null;

// The validation was not successful so abort.
// The validation was not successful so stop.
if ($result['check'] === false) {
$message = Text::_('COM_JOOMLAUPDATE_VIEW_UPDATE_CHECKSUM_WRONG');
$messageType = 'error';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
// phpcs:enable PSR1.Files.SideEffects

/**
* ComponentDispatcher class for com_admin
* ComponentDispatcher class for com_joomlaupdate
*
* @since 4.0.0
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ export default {
}
return this.item.thumb_path.split(Joomla.getOptions('system.paths').rootFull).length > 1
? `${this.item.thumb_path}?${api.mediaVersion}`
? `${this.item.thumb_path}?${this.item.modified_date ? new Date(this.item.modified_date).valueOf() : api.mediaVersion}`
: `${this.item.thumb_path}`;
},
width() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public function deleteAll(?User $user = null): void
$user = Factory::getApplication()->getIdentity() ?: $this->getCurrentUser();
}

// If the user object is a guest (who can't have MFA) we abort with an error
// If the user object is a guest (who can't have MFA) we stop with an error
if ($user->guest) {
throw new RuntimeException(Text::_('JERROR_ALERTNOAUTHOR'), 403);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
abstract class LatestActionsHelper
{
/**
* Get a list of articles.
* Get a list of logged actions.
*
* @param Registry &$params The module parameters.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ customElements.whenDefined('joomla-tab').then(() => {
const installerTabs = document.getElementById('myTab');
const link = installerTabs.querySelector('button[aria-controls=web]');

// Abort if the IFW tab cannot be found
// Stop if the IFW tab cannot be found
if (!link) {
return;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@
event.preventDefault();
}

// Escape is the abort keystroke (for any target element)
// Escape is the cancel keystroke (for any target element)
if (event.keyCode === KEYCODE.ESC && item) {
item.setAttribute('draggable', 'false');
item.setAttribute('aria-grabbed', 'false');
Expand Down Expand Up @@ -573,7 +573,7 @@
switchRowPositions(item, row);
});

// dragend event to clean-up after drop or abort
// dragend event to clean-up after drop or cancelation
// which fires whether or not the drop target was valid
this.addEventListener('dragend', () => {
if (item) {
Expand Down
2 changes: 1 addition & 1 deletion libraries/src/Application/CMSApplication.php
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ function ($systemVariable) use ($input) {
$input->set($systemVariable, null);
}

// Abort when there are invalid variables
// Stop when there are invalid variables
if ($invalidInputVariables) {
throw new \RuntimeException('Invalid input, aborting application.');
}
Expand Down
2 changes: 1 addition & 1 deletion libraries/src/Console/FinderIndexCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ private function purge()
// Attempt to purge the index.
$return = $model->purge();

// If unsuccessful then abort.
// If unsuccessful then stop.
if (!$return) {
$message = Text::_('FINDER_CLI_INDEX_PURGE_FAILED', $model->getError());
$this->ioStyle->error($message);
Expand Down
4 changes: 2 additions & 2 deletions libraries/src/Dispatcher/AbstractModuleDispatcher.php
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public function dispatch()

$displayData = $this->getLayoutData();

// Abort when display data is false
// Stop when display data is false
if ($displayData === false) {
return;
}
Expand Down Expand Up @@ -94,7 +94,7 @@ public function dispatch()
* Returns the layout data. This function can be overridden by subclasses to add more
* attributes for the layout.
*
* If false is returned, then it means that the dispatch process should be aborted.
* If false is returned, then it means that the dispatch process should be stopped.
*
* @return array|false
*
Expand Down
2 changes: 1 addition & 1 deletion libraries/src/Installer/Adapter/LibraryAdapter.php
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ protected function checkExtensionInFilesystem()
// From this point we'll consider this an update
$this->setRoute('update');
} else {
// Abort the install, no upgrade possible
// Stop the install, no upgrade possible
throw new \RuntimeException(Text::_('JLIB_INSTALLER_ABORT_LIB_INSTALL_ALREADY_INSTALLED'));
}
}
Expand Down
2 changes: 1 addition & 1 deletion libraries/src/Schema/ChangeSet.php
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ public function getSchema()
{
$updateFiles = $this->getUpdateFiles();

// No schema files found - abort and return empty string
// No schema files found - stop and return empty string
if (empty($updateFiles)) {
return '';
}
Expand Down
2 changes: 1 addition & 1 deletion libraries/src/Table/ContentType.php
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ public function getContentTable()
$class = $tableInfo->special->class ?? 'Joomla\\CMS\\Table\\Table';

if (!class_implements($class, 'Joomla\\CMS\\Table\\TableInterface')) {
// This isn't an instance of TableInterface. Abort.
// This isn't an instance of TableInterface. Stop.
throw new \RuntimeException('Class must be an instance of Joomla\\CMS\\Table\\TableInterface');
}

Expand Down
2 changes: 1 addition & 1 deletion plugins/system/actionlogs/actionlogs.php
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ public function onAfterRespond()
$result = false;
}

// Abort on failure
// Stop on failure
if (!$result) {
return;
}
Expand Down
2 changes: 1 addition & 1 deletion plugins/system/logrotation/logrotation.php
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ public function onAfterRender()
$result = false;
}

// Abort on failure
// Stop on failure
if (!$result) {
return;
}
Expand Down
2 changes: 1 addition & 1 deletion plugins/system/privacyconsent/privacyconsent.php
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ public function onAfterRender()
$result = false;
}

// Abort on failure
// Stop on failure
if (!$result) {
return;
}
Expand Down
2 changes: 1 addition & 1 deletion plugins/system/updatenotification/updatenotification.php
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ public function onAfterRender()
$result = false;
}

// Abort on failure
// Stop on failure
if (!$result) {
return;
}
Expand Down

0 comments on commit f8578a4

Please sign in to comment.