[4.0] rework language handling in module emptystate (#34144)

* rework language handling in module emptystate

* add isset wrapper

layouts/joomla/content/emptystate_module.php

@@ -9,18 +9,29 @@
 
 defined('_JEXEC') or die;
 
+use Joomla\CMS\Factory;
 use Joomla\CMS\Language\Text;
 
 $textPrefix = $displayData['textPrefix'];
 $icon = $displayData['icon'] ?? 'icon-copy article';
 $componentLangString = $textPrefix . '_EMPTYSTATE_TITLE';
 $moduleLangString = $textPrefix . '_EMPTYSTATE_MODULE_TITLE' . (array_key_exists('textSuffix', $displayData) ? $displayData['textSuffix'] : '');
-$moduleTitle = Text::_($moduleLangString);
 
-$title = $displayData['title']
-	?? ($moduleTitle != $moduleLangString
-		? Text::_($moduleTitle)
-		: Text::_($componentLangString));
+// Did we have a definitive title provided to the view?
+if (isset($displayData['title']))
+{
+	$title = $displayData['title'];
+}
+// Can we find a *_EMPTYSTATE_MODULE_TITLE translation?
+elseif (Factory::getApplication()->getLanguage()->hasKey($moduleLangString))
+{
+	$title = Text::_($moduleLangString);
+}
+// Else use the components *_EMPTYSTATE_TITLE string.
+else
+{
+	$title = Text::_($componentLangString);
+}
 ?>
 <div class="mb-4">
 	<p class="fw-bold text-center text-muted">