Avoid some redundant calls of $(this)

joomla · Jan 17, 2018 · fdd2ac3 · fdd2ac3
1 parent ddbe7a0
commit fdd2ac3
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/administrator/templates/isis/js/template.js b/administrator/templates/isis/js/template.js
@@ -84,15 +84,16 @@ jQuery(function($)
 		{
 
 			// Set max-height (and width if scroll) for dropdown menu, depending of window height
-			var $dropdownMenu    = $(this).children('ul'),
+			var $self            = $(this),
+				$dropdownMenu    = $self.children('ul'),
 				windowHeight     = $w.height(),
-				linkHeight       = $(this).outerHeight(true),
+				linkHeight       = $self.outerHeight(true),
 				statusHeight     = $('#status').outerHeight(true),
 				menuHeight       = $dropdownMenu.height(),
 				menuOuterHeight  = $dropdownMenu.outerHeight(true),
 				scrollMenuWidth  = $dropdownMenu.width() + 15,
 				maxHeight        = windowHeight - (linkHeight + statusHeight + (menuOuterHeight - menuHeight) + 20),
-				linkPaddingLeft  = $(this).children('a').css('padding-left');
+				linkPaddingLeft  = $self.children('a').css('padding-left');
 
 			if (maxHeight < menuHeight)
 			{
@@ -106,9 +107,9 @@ jQuery(function($)
 			$dropdownMenu.css('max-height', maxHeight);
 
 			// Get the submenu position
-			linkWidth   = $(this).outerWidth(true);
+			linkWidth   = $self.outerWidth(true);
 			menuWidth   = $dropdownMenu.width();
-			offsetLeft  = Math.round($(this).offset().left) - parseInt(linkPaddingLeft);
+			offsetLeft  = Math.round($self.offset().left) - parseInt(linkPaddingLeft);
 
 			emptyMenu.empty().hide();
 
@@ -120,7 +121,7 @@ jQuery(function($)
 				dropdown        = $self.next('ul'),
 				submenuWidth    = dropdown.outerWidth(),
 				offsetTop       = $self.offset().top,
-				linkPaddingTop  = parseInt(dropdown.css('padding-top')) + parseInt($(this).css('padding-top')),
+				linkPaddingTop  = parseInt(dropdown.css('padding-top')) + parseInt($self.css('padding-top')),
 				scroll          = $w.scrollTop() + linkPaddingTop;
 
 			// Set the submenu position