svg uploads (#38545)

joomla · Sep 14, 2022 · feca190 · feca190
1 parent f10f221
commit feca190
Showing 1 changed file with 13 additions and 2 deletions.
diff --git a/libraries/src/Helper/MediaHelper.php b/libraries/src/Helper/MediaHelper.php
@@ -326,9 +326,20 @@ public function canUpload($file, $component = 'com_media', $allowedExecutables =
 
             $svgErrors = $sanitizer->getXmlIssues();
 
-            // We allow comments
+            /*
+            * We allow comments and temp fix for bugs in svg-santitizer
+            * https://github.com/darylldoyle/svg-sanitizer/issues/64
+            * https://github.com/darylldoyle/svg-sanitizer/issues/63
+            * https://github.com/darylldoyle/svg-sanitizer/pull/65
+            * https://github.com/darylldoyle/svg-sanitizer/issues/82
+            */
             foreach ($svgErrors as $i => $error) {
-                if ($error['message'] === 'Suspicious node \'#comment\'') {
+                if (
+                    ($error['message'] === 'Suspicious node \'#comment\'')
+                    || ($error['message'] === 'Suspicious attribute \'space\'')
+                    || ($error['message'] === 'Suspicious attribute \'enable-background\'')
+                    || ($error['message'] === 'Suspicious node \'svg\'')
+                ) {
                     unset($svgErrors[$i]);
                 }
             }