Remove unused fieldsets from Category List #10055
Conversation
|
Integration tab for rss feeds is used - you can see that by viewing the source with feeds on and feeds off Options is used - you can see this by setting the first option - show title to hide This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10055. |
|
@smz Sure you changed the righ file? I would expect the categoy list to be "components/com_content/views/categories/tmpl/default.xml" and not "components/com_content/views/category/tmpl/default.xml", which is the one you changed. The latter one is the one where you also can find the blog views, so there the article-related options should be kept, or am I wrong? This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10055. |
|
Closed as this is simply wrong This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10055. |
|
@richard67 the xml for the "Category Blog is "components/com_content/views/category/tmpl/blog.xml" (not "default.xml") |
|
And what is "components/com_content/views/categories/" good for then? |
|
it is for the "List All Categories" view/menu item |
|
It doesnt matter what file it is. As I stated before the options are in use On 22 April 2016 at 23:21, Richard Fath notifications@github.com wrote:
Brian Teeman |
|
No Brian, they are not: maybe just the title thing (I'm checking right now), but not all the others... think it over... |
|
@smz Ah I see, thanks for the info. |
|
I cant help it if you are wrong but i can stop you having bad code accepted On 22 April 2016 at 23:25, Richard Fath notifications@github.com wrote:
Brian Teeman |
|
Sorry, Brian, you're wrong: the title is controlled by the "Category Title" option in the "Category" tab, not in the "Options" tab. Please test... |
|
And as far as regards the RSS feed there is not a single line of PHP code referencing it in the view. Please review... |
|
The RSS stuff is coming from the parent Don't just look at the single class and assume it's unused. You also have to look at parent classes in some cases. |
... oops! Your opinion about article's option @mbabker ? |
|
I don't know. Without explicitly tracing every single option you can't say what's used or not used where. There's a part of me that doubts though that an entire tab is totally ignored. |
|
As you dont seem to believe me I made a video of core joomla with testing https://www.dropbox.com/s/j0aooskw0g9ru4z/10055.mp4?dl=0 On 22 April 2016 at 23:37, Michael Babker notifications@github.com wrote:
Brian Teeman |
|
The video is the proof - I didnt just close the PR because I dont like you. On 22 April 2016 at 23:42, Michael Babker notifications@github.com wrote:
Brian Teeman |
|
Apart the RSS thing (with which I've to admit I'm not familiar, and which I'm reverting) my rationale is the if that there is not a single point in the view's template where those option are referenced (and we are talking about options that should have a visible effect on the generated view), then the options are "unused". But I might be wrong: I see while I'm writing the @brianteeman has prepared a video to look at... give me the time to watch it, please... |
|
Ya know what, I change my mind. I have no freakin' clue anymore what's used where or not used. A search on the Even if it isn't, if a template's implemented the param though, it's a B/C break. And people wonder why I hate how many options are in the Joomla UI... |
I don't think so as in case of an override also the xml should be overridden (or am I wrong ?) |
|
You can create a layout override without creating a XML override. |
|
I've watched your screen capture and I totally agree as far as regards the RSS feed thing. I was wrong on that. As far as regards the article titles appearing/disappearing in the single article view... I don't understand... is it because the "Category List" is the only menu item "controlling" the the article view? |
|
Another thought dawned on me. The params may not even apply directly to the category view but rather articles on the article view which have inherited the menu item params for its parent category view. Translation. I ain't got a clue, and I honestly don't care enough to find out. There are too many possible combinations to test effectively. |
Yes, I think it depends on if you have a menu item for the single article or not. |
Yes... I guess it all comes from the "somehow unpredictable" or at least "difficultly predictable" way the router associates "things" and what comes in control as far as regards options... |
|
No it is perfectly predictable and working exactly how it is supposed to be On 23 April 2016 at 00:01, Sergio Manzi notifications@github.com wrote:
Brian Teeman |
Have a look at #9717 ... |
|
Anyway ... even if this PR was wrong, I learned something new from it. |
me too... |
|
Question is if it is worth to keep that all in mind when things will soon change completely with 4.0 👅 |
|
was joking |
|
soon? 😕 |
|
months ago if looking at old project schedules 😄 |
|
It's really simple. The options aren't used in the cageories list, but they are used once you navigate from the categories list down to a single category or article view. Then the params from the menu take precedence over the global component params and you can eg hide the author in that specific menu item. |
Summary of Changes
In "Category List" we have (since Joomla 3.0 if I'm not mistaken) two fieldsets and related "tabs" which I think are of no usage: "Options" (which is for setting articles options) and "Integration" (for setting RSS feeds related options), but in "Category List" we just build up a list of articles with just links to them: no article has ever been displayed by that view and hence all related options are totally ineffective.
Testing Instructions
Not much to test... everything should work "business as usual"...