-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Probably outdated file in components/com_contact #10694
Comments
Yes, it's outdated since J!1.6.? when contact was moved to JForm. form.xml was replaced by contact.xml then. Found no issues in com_contact after I've deleted form.xml from current staging installation. |
Please test PR 10730 |
I am guessing that it was kept originally because a third party template On 5 June 2016 at 09:55, bertmert notifications@github.com wrote:
Brian Teeman |
@brianteeman You say that the XML file should be marked as deprecated prior that it can be removed. How can you mark an XML file as deprecated? I've seen functions being marked that way - but XML files? This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10694. |
Fair point. Can you submit a PR to remove it? This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10694. |
Please see PR #10786 This PR currently only removes the file form.xml from future versions. I think the file shall be added to This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10694. |
To consider it as deprecated but still let use it for B/C (unlikely used but one never knows...), it should not be added to deleteUnexistingFiles() in script.php. |
Then it can't be deleted at all because then it's inconsistent (the file exists on sites created and updated from 1.6 to 3.5.1 but not 3.6 or later). Either it goes completely away in one pull request or it stays in the system. |
Closed as there is a PR This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10694. |
In searching for all XML forms that define the field "custom_reply" I found beside some other files the file
components/com_contact/models/forms/form.xml
But when I checked the contents of this XML file and compared it with the other XML files I found I had the strong suspicion that this file is no longer up-to-date and is no longer used.
Main reason for this suspect is that some of the message defines used in that XML file don't exist in any language file, e.g. "CONTACT_CONFIG_CUSTOM_REPLY_DESC" or "Contact_Email_BANNED_SUBJECT_DESC" (note the upper/lower case form).
Can you please check whether this XML file is still in use?
The text was updated successfully, but these errors were encountered: