Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form Field Media, preview="true" not working anymore #10800

Closed
Werbschaft opened this issue Jun 12, 2016 · 8 comments
Closed

Form Field Media, preview="true" not working anymore #10800

Werbschaft opened this issue Jun 12, 2016 · 8 comments

Comments

@Werbschaft
Copy link
Contributor

Werbschaft commented Jun 12, 2016

Normally it was possible to add to the Joomla Form Field Media the Parameter preview="true" to show a permanent visible Preview Image of the Field. Now this isn't possible anymore! It always shows the "eye symbol". I personally think this is very useless cause the preview Image is very Important. Not sure how to fix this, it happens in Joomla 3.6 alpha!

Seems also the default Tooltip was replaced with the Bootstrap Popover. Check the 2 Images. The one on Top was with preview="true", the other one was the default. How can we fix this to work again??

screen shot 2016-06-12 at 10 44 28
screen shot 2016-06-12 at 10 44 28

@dgrammatiko
Copy link
Contributor

The relative code seems to be there: https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/form/field/media.php#L144
But you mention popover(?), if so that's the bootstrap version which might not have that option...

@Werbschaft
Copy link
Contributor Author

Yes sure, I have also checked this Code! But there seems to be no Variable which can control the Output if Tooltip OR default

@dgrammatiko
Copy link
Contributor

@WS-Theme that's by design, you can override the layout and create the output that fits you best

@Werbschaft
Copy link
Contributor Author

Hi dgt41, sorry but how should this work without modify the Core File. I can use in XML only the basic variables that are provided by this form field. Or am I missing something?? If you could provide a Solution that would be awesome.

In the Joomla Docs for this Field we have only these ... and before Joomla 3.6 it works.

https://docs.joomla.org/Media_form_field_type

@dgrammatiko
Copy link
Contributor

@WS-Theme This field layout that you are referring to is not YET shipped with Joomla!. Joomla as for 3.5 and unless #10788 is accepted is not providing a bootstrapped version of the field (meaning that the field IS NOT using bootstrap popup for the preview, but instead the mootools tooltip!). Probably you were testing a PR and you forgot to undo the changes. That said tho, if bootstrap layout is accepted the fixed position will not be part of that, so in that case you will have to override the layout

@brianteeman
Copy link
Contributor

Is there still an issue here or can this be closed


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10800.

@dgrammatiko
Copy link
Contributor

@WS-Theme please test #10889

@brianteeman
Copy link
Contributor

Closed as we have a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants