-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap popup with mootols compatibility #10788
Conversation
@dgt41 Clearly, i don't like the idea of adding an override in Isis template, as this does not allow user to create its own layout override... But your idea of checking if is mootools is a nive approach. Note: in my PR, i've added the new |
I have tested this item ✅ successfully on 2a1b1e4 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10788. |
@JoomliC I think JLayouts overrides are PART of a template, which means you cannot change them (without creating a new template). So, in that sense, templates CAN and SHOULD have their own JLayouts if the required output is different than the standard (/root/layouts). |
@dgt41 I agree, and that's why the standard (BS modal) should not be an override ;-) Could you check again if In the same time, repeatable subform script is not working, as issue with field incrementation: #10772 (comment) |
If you can make major changes to fields without breaking compatibility in their APIs, you can change the stuff. Considering that SqueezeBox and Bootstrap modals don't have compatible JavaScript APIs, that makes anything at least from that perspective difficult to deal with. But what was found in 3.5 testing (IIRC) was that there isn't a clean way to migrate some of these fields from 100% MooTools framework to 100% jQuery/Bootstrap framework without some kind of deep rooted B/C break. So really the only options in that case are either complex configuration directives, new field types, or waiting for 4.0. |
@mbabker with this PR all cases are covered:
|
@mbabker This is why i proposed a new field type build by a new field attribute |
@dgt41 Well, now my mind is better opened ( ;-) ) i will test your PR tomorrow if enough time (children at home this week-end) |
@anibalsanchez @ggppdk can you test this one? It should be fixing #9454 and still providing bootstrapped media field! Thanks |
@Fedik can you review this one? |
Hi, Test instructuions for Mixed mode does not match the code in edit.php. After line 74, there is no immediate ?> and there is a bunch of code until the next ?>. |
@anibalsanchez yup my staging was behind, should be after line 84 |
I have tested this item ✅ successfully on 2a1b1e4 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10788. |
I have tested this item ✅ successfully on 2a1b1e4 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10788. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10788. |
There was a discussion few months ago and due to the B/C break or the addition of an extra html override the decision was to delay this change till J4... |
@dgt41 Thanks for info! 👍 |
Replaced by #10889 Thanks everybody for testing here! |
@brianteeman @wilsonge please remove the milestone here as it get closed without merging as it is moved to a different pull request! |
Joomla 3.5 should had bootstrap modal for form field media but didn't. This fixes that
Summary of Changes
Introduce an option that will provide the needed backwards compatibility.
Testing Instructions
Apply patch
Test creating a new article and that the intro/full text images as well as the tinymce image button still works.
Edit administrator/components/com_content/views/article/tmpl/edit.php
and paste the code bellow after line 84 (just before
?>
)Test again the previous scenario as well as the new buttons that will appear above the tabs. The field should be field with the image selected in the pop up
Keep the changes in edit.php
Rename administrator/templates/isis/html/layouts/joomla/form/field/media.php to xxxmedia.php
Repeat the previous testing steps