Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin menu dropdown in Joomla! 3.6.0 RC1 #10972

Closed
viocassel opened this issue Jun 29, 2016 · 12 comments
Closed

Admin menu dropdown in Joomla! 3.6.0 RC1 #10972

viocassel opened this issue Jun 29, 2016 · 12 comments

Comments

@viocassel
Copy link
Contributor

viocassel commented Jun 29, 2016

Admin menu dropdown in Joomla! 3.5.1

Admin menu dropdown in Joomla! 3.6.0 RC1

This is a bug or a feature? 😕

@brianteeman
Copy link
Contributor

I assume you refer to the missing pointer?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10972.

@viocassel
Copy link
Contributor Author

Yes. And dropdowns appear crooked.

@brianteeman
Copy link
Contributor

Probably related to #9375

On 29 June 2016 at 22:49, Vio Cassel notifications@github.com wrote:

Yes. And dropdowns appear crooked.

https://camo.githubusercontent.com/65c853f6b87aeb80831d5c64052b81aaddfc0a83/687474703a2f2f696d6167652e70726e747363722e636f6d2f696d6167652f30363838633766376637356234653031393933373536626666366533646638622e706e67


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10972 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8SMU2fs6ex4HRjDxp-VQjeL-Es7eks5qQuhUgaJpZM4JBmAA
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@StefanSTS
Copy link
Contributor

StefanSTS commented Jun 30, 2016

.navbar .nav > li ul has the overflow-y and overflow-x set to auto and hidden, this causes that the triangle is not appearing, since it is attached to the ul with the pseudo selector. It is positioned outside the ul container and is therefore not shown.

A solution could be to attach it to the higher level li.dropdown.open with the :after selector. Haven't tried that though.

@StefanSTS
Copy link
Contributor

For the difference in height for the second ul: There is a margin: 2px 0 0; on .dropdown-menu. This causes the submenu to move down 2px while the first dropdown has that overridden in .navbar .nav > li ul with margin: 0;.
Suggested solution would be to remove the 2px top margin on .dropdown-menu.

@brianteeman
Copy link
Contributor

@JoomliC could you take a look please


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10972.

@RonakParmar
Copy link

I have checked in Joomla 3.5.1 and latest Joomla Staging branch and I am able to reproduce this issue.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10972.

@RonakParmar
Copy link

I have changes administrator template to "hathor" and menu selection is working fine in this template, but having issue in "isis" template.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10972.

@kalpeshtailored
Copy link

I am able to reproduce same issue


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10972.

@cyrezdev
Copy link
Contributor

cyrezdev commented Jul 1, 2016

@brianteeman i don't know exactly why you request me here to have a look... maybe you mean @C-Lodder ;-)

I have checked a bit, and you're right, issue is related to #9375
The missing pointer is due to the overflow set to the all container (ul) : https://github.com/joomla/joomla-cms/pull/9375/files#diff-92bd4bc9fc868397bd2dcf5f303c0ec4R7160
And the extra margin at top of sub menu : https://github.com/joomla/joomla-cms/pull/9872/files#diff-6337832bd45e0f9af1521049cb78e03eR77 (a PR which was supposed to fix those 2 issues already reported here : #9841 )
Here, i wonder why +5 (if set to 8, it's ok for sub menu top placement, but i don't think using value inside the script will be consistent in the future...) or -13 in script template.js ?

As no PR yet, i have created one #10987 (@StefanSTS you fix proposal for missing pointer is the right one! 👍 )
@C-Lodder could check this PR too ;-)

Thanks!

@brianteeman
Copy link
Contributor

Please test #10987


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10972.

@brianteeman
Copy link
Contributor

Closed as we have a PR


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10972.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants