Added Feature items filter to mod_articles_news #11540
Conversation
The feature item filter was already available for the mod_articles_latest module, but that is just a list. All code was slightly modified from the mod_articles_latest module. Language File - Added three variables (description, lable and value) Helper - Copy and pasted the switch from mod_articles_latest (same parameter ordering too) Parameter file - Added field after order (mirroring _latest)
| @@ -4,6 +4,8 @@ | |||
| ; Note : All ini files need to be saved as UTF-8 | |||
|
|
|||
| MOD_ARTICLES_NEWS="Articles - Newsflash" | |||
| MOD_ARTICLES_NEWS_FIELD_FEATURED_DESC="Show or hide articles designated as featured." | |||
There was a problem hiding this comment.
For consistency with other language strings can you change this to
Select to Show, Hide, or Only display Featured Articles.
There was a problem hiding this comment.
I can, but this is consistent with en-GB.mod_articles_latest.ini line 10. Do you want me to change verbiage there too?
There was a problem hiding this comment.
I need to check if those two have the options for featured only to see if they need to be updated - but that is beyond the scope of this PR anyway. The string I chose was from mod_articles_category
There was a problem hiding this comment.
@nickyeoman if you can change the string hen I can make this RTC and it can be merged -thanks
|
Small change: Without the Oxford Comma? |
|
@Hils lets leave it in for now so it is identical to the other string and then the "issue" of the Oxford comma can be addressed in a single pull request |
|
I have tested this item ✅ successfully on b0e6d3d This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11540. |
|
I have tested this item ✅ successfully on b0e6d3d This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11540. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11540. |
|
@nickyeoman could you have a look at the conflicts and resolve them, thanks! |
|
@nickyeoman please see: https://github.com/nickyeoman/joomla-cms/pull/1 and merge to fix the conflicts |
|
New PR: #12547 |
Pull Request for Issue #11539 .
Summary of Changes
The feature item filter was already available for the
mod_articles_latest module, but that is just a list.
All code was slightly modified from the mod_articles_latest module.
Testing Instructions
Documentation Changes Required
https://help.joomla.org/proxy/index.php?keyref=Help36:Extensions_Module_Manager_Articles_Newsflash
Should be updated to include the featured articles filter
Just copy and paste what is here: https://help.joomla.org/proxy/index.php?keyref=Help36:Extensions_Module_Manager_Latest_News