Added Feature items filter to mod_articles_news | Fix merge conficts for #11540 #12547

Merged
merged 5 commits into from Nov 20, 2016

Conversation

Projects
None yet
7 participants
@zero-24
Contributor

zero-24 commented Oct 25, 2016

Pull Request for Issue #11539 . And redo of #11540

Summary of Changes

The feature item filter was already available for the
mod_articles_latest module, but that is just a list.
All code was slightly modified from the mod_articles_latest module.

Testing Instructions

  • Login to the joomla administrator
  • Add the module Articles - Newsflash
  • You should now see a filter parameter for featured

Documentation Changes Required

https://help.joomla.org/proxy/index.php?keyref=Help36:Extensions_Module_Manager_Articles_Newsflash
Should be updated to include the featured articles filter
Just copy and paste what is here: https://help.joomla.org/proxy/index.php?keyref=Help36:Extensions_Module_Manager_Latest_News

Nick Yeoman - PC and others added some commits Aug 10, 2016

Nick Yeoman - PC
Added Feature items filter to mod_articles_news
The feature item filter was already available for the
mod_articles_latest module, but that is just a list.
All code was slightly modified from the mod_articles_latest module.

Language File - Added three variables (description, lable and value)
Helper - Copy and pasted the switch from mod_articles_latest (same
parameter ordering too)
Parameter file - Added field after order (mirroring _latest)
@zero-24

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Oct 25, 2016

Contributor

Please give that a quick test against 3.7.x to be back RTC 😄

Contributor

zero-24 commented Oct 25, 2016

Please give that a quick test against 3.7.x to be back RTC 😄

@rdeutz rdeutz changed the base branch from 3.7.x to staging Oct 25, 2016

@brianteeman brianteeman added PR-staging and removed PR-3.7.x labels Oct 29, 2016

@zero-24

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Nov 13, 2016

Contributor

Can we get a test for this merge conflict PR?

Contributor

zero-24 commented Nov 13, 2016

Can we get a test for this merge conflict PR?

@yvesh

This comment has been minimized.

Show comment
Hide comment
@yvesh

yvesh Nov 19, 2016

Member

I have tested this item successfully on 19736f1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12547.

Member

yvesh commented Nov 19, 2016

I have tested this item successfully on 19736f1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12547.

@zero-24

This comment has been minimized.

Show comment
Hide comment
@zero-24

zero-24 Nov 19, 2016

Contributor

RTC as it is just a redo of the original tested PR


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12547.

Contributor

zero-24 commented Nov 19, 2016

RTC as it is just a redo of the original tested PR


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12547.

@rdeutz rdeutz merged commit 9c210b6 into joomla:staging Nov 20, 2016

2 of 3 checks passed

JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed.
Details
continuous-integration/drone the build was successful
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@zero-24 zero-24 deleted the zero-24:11540 branch Nov 20, 2016

roland-d added a commit to roland-d/joomla-cms that referenced this pull request Nov 25, 2016

Merge branch 'staging' into shareable-draft-content-feature
* staging: (98 commits)
  Coding style. PHP constants true, false, and null MUST be in lower case. (#13010)
  Removing duplicated AS in sql query (#13006)
  Fixed typo in comment (#12992)
  Correcting strings in TFA Google plugin (#12980)
  code style changes (#12986)
  Error in sr-YU installation ini file (#12984)
  New DateTime picker (replaces calendar) (#11138)
  Export of Banners Tracks Does Not Export the Banner Name
  fix rues get data (#12763)
  Added Feature items filter to mod_articles_news (#12547)
  fix them all (#12943)
  a11y regression fix (#12935)
  Set correct component id for system links (#12938)
  Fix for Undefined offset in Content History preview popup (#12791)
  remove tab on meta charset (#12895)
  JSession patched to set session _state to 'inactive' when session is closed. (#12928)
  [JHtmlNumber::bytes] Format number according to language (#12929)
  Update edit.php (#12818)
  Update default.xml (#12917)
  Adding the ability to use the global value for character count in newsfeeds (#12869)
  ...
@franz-wohlkoenig

This comment has been minimized.

Show comment
Hide comment
@franz-wohlkoenig

franz-wohlkoenig Jan 19, 2017

There's a "Show Images" in Module, but neither Intro Image or Full Artivle Image nor Image append by Editor is shown.

There's a "Show Images" in Module, but neither Intro Image or Full Artivle Image nor Image append by Editor is shown.

@zero-24

This comment has been minimized.

Show comment
Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment