Added Feature items filter to mod_articles_news | Fix merge conficts for #11540 #12547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The feature item filter was already available for the mod_articles_latest module, but that is just a list. All code was slightly modified from the mod_articles_latest module. Language File - Added three variables (description, lable and value) Helper - Copy and pasted the switch from mod_articles_latest (same parameter ordering too) Parameter file - Added field after order (mirroring _latest)
|
Please give that a quick test against 3.7.x to be back RTC 😄 |
|
Can we get a test for this merge conflict PR? |
|
I have tested this item ✅ successfully on 19736f1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12547. |
|
RTC as it is just a redo of the original tested PR This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12547. |
joomla-cms-bot
added
RTC
joomla-cms-bot
removed
Language Change
roland-d
added a commit
to roland-d/joomla-cms
that referenced
this pull request
Nov 25, 2016
* staging: (98 commits) Coding style. PHP constants true, false, and null MUST be in lower case. (joomla#13010) Removing duplicated AS in sql query (joomla#13006) Fixed typo in comment (joomla#12992) Correcting strings in TFA Google plugin (joomla#12980) code style changes (joomla#12986) Error in sr-YU installation ini file (joomla#12984) New DateTime picker (replaces calendar) (joomla#11138) Export of Banners Tracks Does Not Export the Banner Name fix rues get data (joomla#12763) Added Feature items filter to mod_articles_news (joomla#12547) fix them all (joomla#12943) a11y regression fix (joomla#12935) Set correct component id for system links (joomla#12938) Fix for Undefined offset in Content History preview popup (joomla#12791) remove tab on meta charset (joomla#12895) JSession patched to set session _state to 'inactive' when session is closed. (joomla#12928) [JHtmlNumber::bytes] Format number according to language (joomla#12929) Update edit.php (joomla#12818) Update default.xml (joomla#12917) Adding the ability to use the global value for character count in newsfeeds (joomla#12869) ...
|
There's a "Show Images" in Module, but neither Intro Image or Full Artivle Image nor Image append by Editor is shown. |
|
Just implemented to the docs: https://docs.joomla.org/Chunk30:Help-3x-module-site-articles-newsflash#Module |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #11539 . And redo of #11540
Summary of Changes
The feature item filter was already available for the
mod_articles_latest module, but that is just a list.
All code was slightly modified from the mod_articles_latest module.
Testing Instructions
Documentation Changes Required
https://help.joomla.org/proxy/index.php?keyref=Help36:Extensions_Module_Manager_Articles_Newsflash
Should be updated to include the featured articles filter
Just copy and paste what is here: https://help.joomla.org/proxy/index.php?keyref=Help36:Extensions_Module_Manager_Latest_News