Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi level subform #11551

Closed
webchun opened this issue Aug 11, 2016 · 17 comments
Closed

Multi level subform #11551

webchun opened this issue Aug 11, 2016 · 17 comments

Comments

@webchun
Copy link

webchun commented Aug 11, 2016

Steps to reproduce the issue

screen shot 2016-08-10 at 19 15 05

  • I'm using subform for my module parameters
  • I have this code on my xml :
<field name="items" type="subform" formsource="modules/mod_modulex/fields/item.xml" min="1" max="4" multiple="true" layout="joomla.form.field.subform.repeatable-table" groupByFieldset="true" label="Subform Field" description="Subform Field Description" />
  • This is the content of the item.xml
<?xml version="1.0" encoding="UTF-8"?>
<form>
<fieldset name="field_items" label="Fields">
        <field
            name="field_label"
            type="text"
            label="title"
            size="40" />

        <field name="subchild_items" type="subform" formsource="modules/mod_modulex/fields/subchild_items.xml" max="20" multiple="true" layout="joomla.form.field.subform.repeatable-table" groupByFieldset="true" label="value" description="Checkbox Items" showon="field_type:4"/>
</fieldset>
</form>

and this is the content of subchild_items.xml

<?xml version="1.0" encoding="UTF-8"?>
<form>
<fieldset name="field_items2" label="Fields">
    <field
        name="subchild_value"
        type="text"
        default="0"
        label="Value"
    />
</fieldset>
</form>

Expected result

The subform works properly

Actual result

It works partially. The subchild subform is displayed, but it's breaking the next fieldset, and every time I added the new item, the subchild subform's field is displayed twice

System information (as much as possible)

Joomla 3.6.2

Additional comments

@webchun webchun changed the title Two level subform Multi level subform Aug 11, 2016
@Fedik
Copy link
Member

Fedik commented Aug 11, 2016

Multi level subform in multiple=true mode does not supported for now (due some limitation).
However in single (multiple=false) mode should work, in theory, but I not tried 😄

@webchun
Copy link
Author

webchun commented Aug 11, 2016

@Fedik Ah ok ;)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11551.

@gaelicwinter
Copy link

@Fedik, any idea when the multilevel subform code might be available? I'm stuck with the need, and while I probably don't have as much experience with jquery as you, I am happy to help in any way I can. It will probably take me 2-3 weeks to come up with my own solution to use in my own joomla site, and I'd rather devote that to the core project if possible. I'm good with joomla, php, css, etc, and ok with js and such.

Happy to contribute if I can.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11551.

@Fedik
Copy link
Member

Fedik commented Aug 17, 2016

Some months ago I tried to fix it for my own project, but did not got any success with multilevel subform.
There need some more coding and changes in the script and in the layout.
I am not sure that it can be fixed soon.

@olejenya
Copy link

showon = "test: 1" This is just the minimum that can be used in multiple = "true", that everything was beautiful.

It would be nice to make this type of field that would work all. The modules have become much brighter and more convenient to the end user ispolbzovanii Joomla!

showon="test:1" Это как раз тот минимум , который можно было использовать в multiple="true" , что бы все было красиво.
Было бы неплохо сделать этот тип поля , что бы все работало. Модули стали бы намного ярче и удобней в исполбзовании для конечного пользователя джумлы


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11551.

@hennysmafter
Copy link

hennysmafter commented Nov 8, 2016

@Fedik Is there a indication when this is going to be fixed/implemented. Because as of now we can't include any subform from other extensions that have their own subforms.

multiple=true / multiple=false both give the same results in both cases it does not save any values. See this ticket for a bit more info:#12838

@Fedik
Copy link
Member

Fedik commented Nov 8, 2016

Is there a indication when this is going to be fixed/implemented

no idea, this feature even not planned before.
some day, maybe 😄

@hennysmafter
Copy link

@Fedik So what now how to get this feature on the Agenda?

@Fedik
Copy link
Member

Fedik commented Nov 8, 2016

the topic already opened, need to wait for someone who know how and a have time to fix it

@brianteeman
Copy link
Contributor

brianteeman commented Nov 8, 2016 via email

@hennysmafter
Copy link

@Fedik Ah oke. As long as it is mentioned it can't be forgotten. As I think it would be nice to have.
@brianteeman I know that and because of them we get awesome features!

@ghost
Copy link

ghost commented Apr 6, 2017

@webchun are com_fields a Solution?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11551.

@Fedik
Copy link
Member

Fedik commented Apr 6, 2017

@franz-wohlkoenig nope

@ghost
Copy link

ghost commented Apr 6, 2017

thanks @Fedik, set Status on "Needs Review".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11551.

@laoneo
Copy link
Member

laoneo commented Sep 5, 2017

This issue can be closed as we have a pr for it #17552.

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/11551

@ghost
Copy link

ghost commented Sep 5, 2017

closed as having Pull Request #17552

Thanks for Hint, @laoneo


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11551.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants