Banner Finish Publishing field date and time issue

[JamalTailored]

Steps to reproduce the issue

1. Create banner with image and select Publishing tab
2. Set past time(less then current time) in Finish Publishing field and save banner
3. Go to the Extensions -> Modules menu.
4. Click on New button, select "Banners" from the selection list
5. You will be redirected to the module detail page
6. You need to write module name and select Banner[banner] position (according to template) and save module
7. Go to site side

Expected result

if admin selected a past time (less then current time)in Finish Publishing field then banner should not be displayed.

Actual result

Getting following error :

"jos-Error: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 3 SQL=UPDATE #__banners SET impmade = (impmade + 1) WHERE id IN ()"

System information (as much as possible)

PHP Version 5.5.9-1ubuntu4
Joomla! Version Joomla! 3.6.3-dev Development [ Noether ] 5-August-2016 00:32 GMT
Joomla! Platform Version Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT

Additional comments

[brianteeman]

Pretty sure you did not mean to tag this with MS SQL

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11969.}

[brianteeman]

How did you do step 2 - I always get
Error
Save failed with the following error: Item start publishing date must be before finish publishing date

[JamalTailored]

I have manually edited time in past.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11969.}

[brianteeman]

OK so having manually set the banner to be expired and then displaying the banners on the front end I can not replicate your issue and get the expected result you identified.

Please can you retest and confirm that you can replicate this with one of the default templates and on a clean install of the latest staging release

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11969.}

[peterwouda]

Same problem here, exept in my case I don't use banners and then the same SQL-error appears. But after adding a dummy-banner the error is gone. Deleting the banner causes the error again.

[peterwouda]

[peterwouda]

I do not have overrides in /html/com_banners

[peterwouda]

OK, thanks! I will send it to you in about an hour or so. First I will recover the live-site.

[alikon]

i'm unable to reproduce this issue under 3.6.3

finish publishing was changed via phpmyadmin cause you cant't set finish publishing < start publishing via banner edit

[peterwouda]

It works fine now, no exceptions after testing with adding and deleting
banners. Thanks!

Peter

Op 22-10-2016 om 15:03 schreef Phil Taylor:

I have raised a PR #12508
#12508 - that addresses a
code quality issue, that causes this exception, Please test this - I
have applied this on @peterwouda https://github.com/peterwouda site
and on another and it fixes both sites - its a fringe case to
replicate, but the code was of poor quality in this area anyway - the
PR makes it more reliable.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11969 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARfuknjXFXdJVNFPTpfgxzlpjMSlqKc9ks5q2gmbgaJpZM4J22h0.

[davenir]

I just spent half a day attempting to sort this issue after upgrading to 3.6.4.
Creating a banner or (inexplicably)changing to default template sorted it.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11969.}

[davenir]

No there were no overrides for banners. The theme was "University" by Gavick which I reinstalled again to see if this was the issue but the error persisted. Also no relevant apache errors. Switching theme removed the issues. Only when I finally disabled Gavick's custom error page and got a more verbose error was I able to actually view the specific error..which led me here..

Disabling the banner STILL causes the issue unless I switch to Beez or similar default theme. I can provide URL if you're curious.

[davenir]

No problem Phil - publishing a non-visible banner is as good a fix as I need for the moment!

[davenir]

Of course - I just meant that the site is online and working. I've added the site to myjoomla.com. ID: 11195130 if you're interested.

[davenir]

My apologies. I've submitted them as you did originally specify.

[brianteeman]

Closed as requested

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11969.}