Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching title is not highlighted in the search results #11996

Closed
hakanara opened this issue Sep 9, 2016 · 9 comments
Closed

Matching title is not highlighted in the search results #11996

hakanara opened this issue Sep 9, 2016 · 9 comments

Comments

@hakanara
Copy link

hakanara commented Sep 9, 2016

Steps to reproduce the issue

Activate the search content plugin and search a word that is found in one of the titles of an article.

Expected result

  1. The search phrase that matches the word in the content or the article title should be highlighted.
  2. If the word in the title matches, that should be displayed above the other results where the match is within the content. (this is generally what we are used to see from Google search results.)

Actual result

  1. Matching word in the title is not highlighted but only the matching content is.
  2. Articles are ordered according to the article id but not according to the matching titles first and then the matching content.

System information (as much as possible)

Joomla 3.6.2

Additional comments

Keep up the good work you all Joomla loverz :-)

@hakanara hakanara changed the title Matching search title is not highlighted in the search Matching search title is not highlighted in the search results Sep 9, 2016
@hakanara hakanara changed the title Matching search title is not highlighted in the search results Matching title is not highlighted in the search results Sep 9, 2016
@brianteeman
Copy link
Contributor

Matching word in the title is not highlighted but only the matching content is.

confirmed

Articles are ordered according to the article id but not according to the matching titles first and then the matching content.

Not confirmed - they are first ordered by title - if you enable debug in the global configuration it will show the queries being performed and you will see this.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11996.

@hakanara
Copy link
Author

Hi @brianteeman. I respect very much your time and efforts for Joomla. I have been following ytou for a very long time. So, I would like to thank you once more.

For the part that you do not confirm, I tested it with my running web site one more time. I can still confirm it.
I have also set up a fresh Joomla installation with test data (Teaching Joomla in English). After setting it up, I have searched the Word Joomla in the search box.

Here is the order of the search results:

  1. Templates
  2. Protostar
  3. Plugins
  4. Park Blog
  5. Navigation Modules
  6. Modules
  7. Languages
  8. Joomla!
  9. Extensions

As you see the article with Joomla is not ranking 1 but 8.
I am talking about "search content plugin" which is available on this test site by default.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11996.

@brianteeman
Copy link
Contributor

Strange - I just retested and can confirm


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11996.

@brianteeman
Copy link
Contributor

OK I can see what is happening. All the results are being ordered by the title which is why in your example the article with a title of Joomla is not the first article. So it looks like the group clause is not correct


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11996.

@hakanara
Copy link
Author

Thank you very much @brianteeman. I am very grateful. Another interesting Joomla issue is on the way when this one is resolved. :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11996.

@brianteeman
Copy link
Contributor

Not saying I know how to resolve it - just that I now understand what the
issue is

On 29 October 2016 at 21:08, hakanara notifications@github.com wrote:

Thank you very much @brianteeman https://github.com/brianteeman. I am
very grateful. Another interesting Joomla issue is on the way when this one

is resolved. :-)

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/tracker/
joomla-cms/11996.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11996 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8bCnuOenuuNj-POtD0j16pSToa1Aks5q46fUgaJpZM4J47E3
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

@weeblr
Copy link
Contributor

weeblr commented Jun 3, 2017

Looking at this, #JAB17


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11996.

@weeblr
Copy link
Contributor

weeblr commented Jun 3, 2017

Made a PR for the highlighting part. The ordering appears fairly complex, so I will leave open for now. Maybe worth opening a separate issue just for the ordering.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11996.

@hakanara
Copy link
Author

hakanara commented Aug 1, 2017

I have opened another issue #17361 about the ordering so you can close this issue. Thank you very much for the highlighting part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants