Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with checkout system #13120

Closed
smehrbrodt opened this issue Dec 7, 2016 · 7 comments
Closed

Problems with checkout system #13120

smehrbrodt opened this issue Dec 7, 2016 · 7 comments

Comments

@smehrbrodt
Copy link
Contributor

smehrbrodt commented Dec 7, 2016

When editing an article, it gets the status "Checked out". That prevents any other user to edit the same article at the same time.
The status will be reset when closing the article.
However, when closing the window/tab with the edit form, the checked out status is not being reset.

This can lead to many checked out articles, and users not knowing what causes this.

Maybe we can add some warning message, or release the lock before closing the window.

@brianteeman
Copy link
Contributor

brianteeman commented Dec 7, 2016 via email

@smehrbrodt
Copy link
Contributor Author

As far as I am aware it is not possible to prevent someone closing a browser tab/window and force the display of a message.

It is possible: https://developer.mozilla.org/de/docs/Web/API/WindowEventHandlers/onbeforeunload

Even if it was I'm not convinced it would be a good idea.

As I said, it must not be that we display a warning message, a ping to the Joomla backend "please release this content" would be enough.

@PhilETaylor

This comment was marked as abuse.

@brianteeman
Copy link
Contributor

That link to mozilla.org shows that even if possible it is only supported by a small number of the browsers we use making it functionally useless.

I am closing this at this time as expected behaviour. It could be re-opened if you find a solution that will work with all supported browser.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13120.

@dgrammatiko
Copy link
Contributor

@smehrbrodt could you use #4773 as your base and provide a working solution?

@smehrbrodt
Copy link
Contributor Author

That link to mozilla.org shows that even if possible it is only supported by a small number of the browsers we use making it functionally useless.

That page is called WebAPI - not Firefox API. It's just hosted by mozilla. And the page states that it works in all major browsers, even in IE since version 4.

If you close the browser then it quite rightly remains checked out. This is by design.

What benefit does one have by that "design" decision?

The problem is, that there is no easy way to just "view" an article in the backend - to do that, you need to go to the edit view. And if you just cared about viewing, you usually do not care to save or close the article using the Joomla buttons - but might just close the window/tab.

Maybe another possibility would be to take the lock only when starting to actually edit something? Or have the locks automatically been reset after a period of inactivity? Or something else?
There must be some solution for this.

@brianteeman
Copy link
Contributor

brianteeman commented Dec 8, 2016 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants