REGRESSION Install multiple language at once fails

[svenbluege]

Steps to reproduce the issue

1. open Joomla! lanugage manager
2. click "install languages" button in the toolbar
3. select two random languages
4. click the install button in the toolbar

Expected result

The two selected languages are installed.

Actual result

An error message appears:

Fatal error: Nesting level too deep - recursive dependency? in /var/www/eventgallery/tests/joomla-cms3/libraries/joomla/event/dispatcher.php on line 197

System information (as much as possible)

• PHP 7
• Joomla 3.7.0-dev
• LAMP

Additional comments

Installing those two languages one after another works. I use the JoomlaBrowser Codeception class to create a multilanguage environment. This is where I encountered this error.

[brianteeman]

I used to do this many times during testing without any issues but today I can confirm the issue with the same error message. It must be a recent commit

[Bakual]

@mbabker Could that be related to #12977 as it has been merged yesterday and deals with installing packages.

[brianteeman]

Also #13122

…

On 7 December 2016 at 20:55, Thomas Hunziker ***@***.***> wrote: @mbabker <https://github.com/mbabker> Could that be related to #12977 <#12977> as it has been merged yesterday and deals with installing packages. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#13124 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABPH8TCgFwnfHB5vsjVmIeNIVey_-aPiks5rFx0ogaJpZM4LHEq_> .

-- Brian Teeman Co-founder Joomla! and OpenSourceMatters Inc. https://brian.teeman.net/ <http://brian.teeman.net/>

[andrepereiradasilva]

this issue also happens on joomla installation if one try install two or more languages at same time (but we get no error there thanks to the "excelent" error handling of installation app 😞 ).

but in chrome dev tools one can see the error:

Fatal error: Nesting level too deep - recursive dependency? in /path/to/joomla-staging/libraries/joomla/event/dispatcher.php on line 197

[mbabker]

The only thing I can think of is moving that line loading the in-class event listener to some place where it'll only run once.

On Wed, Dec 7, 2016 at 4:47 PM andrepereiradasilva ***@***.***> wrote: this issue also happens on joomla installation if one try install two or more languages at same time (but we get no error there thanks to the "excelent" error handling of installation app 😞 ). but in chrome dev tools one can see the error: Fatal error: Nesting level too deep - recursive dependency? in /path/to/joomla-staging/libraries/joomla/event/dispatcher.php on line 197 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13124 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAWfoTpUpJcAD_qFigkT_TY1ExZmsFcxks5rFzd-gaJpZM4LHEq_> . --

- Michael Please pardon any errors, this message was sent from my iPhone.

[infograf768]

#13122 is not at stake.
It is indeed related to #12977 as I tested reverting it here.

[mbabker]

Just like I said

The only thing I can think of is moving that line loading the in-class event listener to some place where it'll only run once.

What's probably happening is the event is getting registered on each install and that's throwing it for a loop. Let's not get trigger happy on the revert button now 😉

[Bakual]

Let's not get trigger happy on the revert button now

Nah, I'm sure you can fix it. I have just no clue about which line you're talking 😄

[mbabker]

https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/installer/adapter/package.php#L118-L119

[alikon]

any feedback #13134

[alikon]

sorry don't consider previuos attempt

[mbabker]

See #13147