Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onChangeState for Extension Manager not present. #13278

Closed
UWiX-nl opened this issue Dec 19, 2016 · 10 comments
Closed

onChangeState for Extension Manager not present. #13278

UWiX-nl opened this issue Dec 19, 2016 · 10 comments

Comments

@UWiX-nl
Copy link

UWiX-nl commented Dec 19, 2016

Steps to reproduce the issue

  1. Go to Backend->Extensions->Manage->Manage and (un)publish an Extension item e.g. "Articles - Archived".
  2. Try to catch the event using OnContentChangeState in a Plugin (why this event? 'cause every other changestate works through this event - so it's expected to use this one ;-) ).

Expected result

The plugin function should be triggered.

Actual result

No result because the trigger does not exists for (un)publishing extensions.

System information (as much as possible)

PHP Version 7.0.9
Web Server Apache 2.4.23 (Win32)
Joomla! version 3.6.5
User Agent Mozilla/5.0 (Windows NT 6.3; WOW64; rv:50.0) Gecko/20100101 Firefox/50.0

Additional comments

Suggestion to add a trigger event to administrator/components/com_installer/models/manage.php called OnExtensionChangeStage. Add the following code at line 140:

$context = $this->option . '.' . $this->name;
JEventDispatcher::getInstance()->trigger('onExtensionChangeState', array($context, $eid, $value));

The event name onContentChangeState is not logical because this event must be started from within a System plugin (if I am right).

@rvbgnu
Copy link
Contributor

rvbgnu commented Jun 3, 2017

Hi @UWiX-nl is this still relevant?
@nibra

@ghost
Copy link

ghost commented Jun 3, 2017

set Status on "Information Required"


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13278.

@ghost
Copy link

ghost commented Jun 22, 2017

If this PR get no Response, it will be closed at 23th July 2017.

@mbabker
Copy link
Contributor

mbabker commented Jun 22, 2017

This issue is still relevant because nobody has implemented the requested feature.

@ghost
Copy link

ghost commented Jun 22, 2017

@mbabker how to manage this?

@mbabker
Copy link
Contributor

mbabker commented Jun 22, 2017

Leave it open. It's a valid outstanding feature request. Either someone will implement it, or a leadership decision gets made at some point that says "sorry, we aren't interested in this" and we close it, or it just sits here collecting dust.

@ghost
Copy link

ghost commented Jun 22, 2017

i'm no Fan of closing Issues and sure it stays open. It's more about how to manage to get a Decision.

@mbabker
Copy link
Contributor

mbabker commented Jun 22, 2017

Nobody from leadership has closed it as a "sorry, we aren't interested" item. So it's up for grabs if someone wants to write the code for this.

@brianteeman brianteeman changed the title onChangeStage for Extension Manager not present. onChangeState for Extension Manager not present. Feb 5, 2018
brianteeman added a commit to brianteeman/joomla-cms that referenced this issue Aug 18, 2018
PR for joomla#13278

Adds a trigger event so that you can capture when an extensin is disabled etc

To test
Apply this PR

and then in plugins\extension\joomla\joomla.php
add this code for testing

	public function onExtensionChangeState($context, $eid, $value)
	{
		die ('caught you');
	}

Now try to disable an extension in the manage screen and you should catch the event and the messaage is displayed
@joomla-cms-bot
Copy link

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/13278

@ghost
Copy link

ghost commented Aug 18, 2018

closed as having Pull Request #21693

mbabker pushed a commit that referenced this issue Aug 21, 2018
PR for #13278

Adds a trigger event so that you can capture when an extensin is disabled etc

To test
Apply this PR

and then in plugins\extension\joomla\joomla.php
add this code for testing

	public function onExtensionChangeState($context, $eid, $value)
	{
		die ('caught you');
	}

Now try to disable an extension in the manage screen and you should catch the event and the messaage is displayed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants