Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor user field can be edit by default in the User Registration page #14049

Closed
AlexRed opened this issue Feb 13, 2017 · 28 comments
Closed

Editor user field can be edit by default in the User Registration page #14049

AlexRed opened this issue Feb 13, 2017 · 28 comments

Comments

@AlexRed
Copy link
Contributor

AlexRed commented Feb 13, 2017

Steps to reproduce the issue

Create some new user field: text, calendar and editor.
In the User Registration page we can not edit the field, but we can edit the editor field. We need to set the ACL permission to edit the field (Edit Custom Field Value ) in "Guest" user groups.

Expected result

no edit the editor user field in the User Registration page with default ACL

Actual result

http://www.alexred.com/joomla/2017/registration-user-field2.png

System information (as much as possible)

Joomla 3.7.0 Beta 3 dev

Additional comments

...for me is better to allow by default the "Edit Custom Field Value" in "Guest" user groups ACL permission. It is not simple for the webmaster know why the users field is not editable

@ghost
Copy link

ghost commented Feb 13, 2017

@AlexRed your additional comment: similar #13753

@AlexRed
Copy link
Contributor Author

AlexRed commented Feb 13, 2017

we can use Contact Field to allow edit it in frontend by Guest?
And the info insert by guest in the contact field Where are going?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14049.

@AlexRed
Copy link
Contributor Author

AlexRed commented Apr 4, 2017

Editor user field can be edit by default in the User Registration page but not work also if set the acl permission, not data saved for the user in the editor field.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14049.

@joomla-cms-bot joomla-cms-bot changed the title Editor user field can be edit by default in the User Registration page Editor user field can be edit by default in the User Registration page Apr 5, 2017
@AlexRed
Copy link
Contributor Author

AlexRed commented Apr 5, 2017

In the latest stagin the Editor user field can be edit by default in the User Registration page but not work if no set the acl permission. Other Field type can't be edit if no ACL permission. Now the Editor user field is ok if you set the ACL permission "Edit Custom Field Value" for Public group


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14049.

@ghost
Copy link

ghost commented Apr 5, 2017

@AlexRed means closing is okay?

@AlexRed
Copy link
Contributor Author

AlexRed commented Apr 5, 2017

Nooooooooo
The problem is in the stagin.
The Editor user field can be edit by default in the User Registration page but not work if no set the acl permission.

@ghost
Copy link

ghost commented Apr 5, 2017

misreading your Comment, so no closing.

@AlexRed
Copy link
Contributor Author

AlexRed commented Apr 5, 2017

oppsss... sorry for my bad english.
Please can you try it and confirm ?

@ghost
Copy link

ghost commented Apr 5, 2017

to be honest: i don't get the Issue-Point. I guess you mean Editor-Field should also get by ACL-Default to not edit.

@AlexRed
Copy link
Contributor Author

AlexRed commented Apr 5, 2017

it is ACL-Default to not edit, but you can edit it :(
But the text not saved in the database

@ghost
Copy link

ghost commented Apr 5, 2017

thanks, got it, set "confirmed" on Issue Tracker.

@AlexRed
Copy link
Contributor Author

AlexRed commented Apr 5, 2017

the same Editor Field in the contact Mail form can be edit when permission is not set but in this case the data is saved or better the data is send in the mail body.

for me an ACL "column" in the field list is important, to show if the field can be edit or no by the users. By default all new field are set to no edit in the ACL but the administrator can't see it.

@infograf768
Copy link
Member

I confirm the issue.
If the Editor field does not allow Public to use it, we have an issue indeed, specially if the field is required.

@infograf768
Copy link
Member

@laoneo @Bakual
please look into this. It is easy to mistake here.
I even get the Readmore and Field by default as editor-xtd buttons.

@laoneo
Copy link
Member

laoneo commented Apr 5, 2017

I guess this is more of a problem of the editor that it doesn't have a disabled mode.

@AlexRed
Copy link
Contributor Author

AlexRed commented Apr 5, 2017

for me an ACL "column" in the field list is important, to show if the field can be edit or no by the public. By default all new field are set to no edit in the ACL but the administrator can't see it.

@AlexRed
Copy link
Contributor Author

AlexRed commented Apr 5, 2017

we can use the "checkbox" icon:
red "checkbox-unchecked" for no permissio for all (default)
green "checkin" if allow for all
checkbox-partial if permission for only some group

@laoneo
Copy link
Member

laoneo commented Apr 5, 2017

Every field has permission
image

@brianteeman
Copy link
Contributor

What is the problem here? You can set the acl.for everything so I don't understand the issue

@AlexRed
Copy link
Contributor Author

AlexRed commented Apr 5, 2017

the User editor field is editable with ACL set to no edit. But not work, no data saved.

@brianteeman
Copy link
Contributor

brianteeman commented Apr 5, 2017 via email

@AlexRed
Copy link
Contributor Author

AlexRed commented Apr 5, 2017

for me yes, why display a field in the User registration form or in the Contact Mail form if it is not editable?
But it can be "required" and block the procedure

@laoneo
Copy link
Member

laoneo commented Apr 5, 2017

That's a different question and a very valid one which nobody raised till now. We can make it that way, when a field is not editable, then it will not be shown. But then I guess we will get tons of requests why a field is not visible just because the permission is wrong set (keep in mind, the edit value permission is initially only allowed for super admins).

@AlexRed
Copy link
Contributor Author

AlexRed commented Apr 5, 2017

But also now I guess we will get tons of requests why a field is visible but no editable, just because the permission is wrong set (by default).
So for me an ACL "column" in the field list is important, to show if the field can be edit or no by the public. By default all new field are set to no edit in the ACL but the administrator can't know it.

@AlexRed
Copy link
Contributor Author

AlexRed commented Apr 5, 2017

and if the Field is not visible we solve the editor problem.

@brianteeman
Copy link
Contributor

Now that I understand what you mean my personal recommendation would be that if a user does not have the acl priviliges to edit a field then it should be disabled but styled to show that you dont have the permission to edit it. We already have similar styling elsewhere for example in the edit profuile page when you have set the option to disable changing the username

@AlexRed
Copy link
Contributor Author

AlexRed commented Apr 5, 2017

but you can't do it for the editor field.
And like for the username is not editable is not editable now the other user custom field, no special styling, only not editable. We need a message about not editable for no permission or similar, but also for the editor field if we decide to show the field also if it is not editable

@Bakual
Copy link
Contributor

Bakual commented Apr 5, 2017

The problem is that the editor formfield (not the custom field itself) doesn't support readonly/disabled states.
It's a duplicate of #13665, thus I'm closing this issue.

@Bakual Bakual closed this as completed Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants