[3.7] Cache changes

[brianteeman]

In 3.7 there are some changes to the cache settings in the Global configuration that dont seem correct to me (I might be missing something)

1. The option to turn on cache is now after the configuration of the cache and not before - this seems wrong?

2. There is a new field to set the path to the cache folder but it does not have a default entry? Shouldnt it have a default of /cache??

[mbabker]

There is a new field to set the path to the cache folder but it does not have a default entry? Shouldnt it have a default of /cache??

No. If $cache_path is set in your configuration.php file, that path is used for all filesystem caching. When it isn't set, the JPATH_CACHE constant is used (administrator/cache, cache, depends on active app). Setting that value lets you move the cache path somewhere else on the system (like outside the web root, but this could be problematic if extensions writing cached images or CSS like galleries or minifiers do sometimes are using the cache path config and not hardcoding the /cache path).

If we're going to set a default value in here, it would have to be done for 4.0 and the JPATH_CACHE constant fully deprecated now and removed there to avoid confusion. Calculating it would be easy, same as we are tmp and administrator/logs for those paths during install.

[brianteeman]

Ah ok - I understand what you mean about the displayed content of the cache path - I would recommend that the description is updated then to reflect that eg changing

COM_CONFIG_FIELD_CACHE_PATH_DESC="Please specify a folder to store cache files."
to
COM_CONFIG_FIELD_CACHE_PATH_DESC="Please specify a writable folder to store cache files if you do not wish to use the default folder."

And what abou the change in order of the fields?

[mbabker]

Not sure on that one, I can only comment in depth on the change I made (exposing cache path config).

[brianteeman]

So are you ok on the changed string? <http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> Virus-free. www.avg.com <http://www.avg.com/email-signature?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail> <#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

…

On 15 March 2017 at 19:22, Michael Babker ***@***.***> wrote: Not sure on that one, I can only comment in depth on the change I made (exposing cache path config). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#14649 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABPH8Sk8w6ktfGXg6grItW6WIrarSHUhks5rmDpzgaJpZM4MeYll> .

-- Brian Teeman Co-founder Joomla! and OpenSourceMatters Inc. https://brian.teeman.net/ <http://brian.teeman.net/>

[mbabker]

Works for me.

[brianteeman]

and it seems that moving the field to the end was my idea to resolve a confusion as to what the values refer to as they also apply to system cache #12742 so I will leave that

[brianteeman]

Closed as we have a PR - thanks @mbabker