New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Drag and Drop Installation with upload box for #14905 #14924
Conversation
I have tested this item ✅ successfully on d66be84 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14924. |
All the JS and CSS should really go into separate files:
|
May I just let the maintenance team to do this since I just follows original code to write it in php. For me, it is make sense to write this css, js in plugin file because we can close them by closing plugin instead couple them in com_installer. |
Agree with @C-Lodder Also, I suggest that the dropbox be a bit different, something like
It would give something like What do you think? |
Not bad, I did the styling change, also added a |
@asika32764 - In J4, we're trying to move ALL Javascript and CSS to the The CSS bit is easy. As for the JS, you'll need to get the
Then get this value in the JS file:
|
hmm, found an issue which is not related to this PR. But in RTL, it is another matter Will create a specific PR |
I know, my code is only against 3.7 now. If I do this staff, I can only move my code since I don't know there may be any break after I moved other code wrote in the past and separated in different plugins. It will be clear that a PR just do one thing. So I suggest make this thing happened after J4 that we can make sure code works currently in 3.7. |
Ok leave it for now, I'll move it myself once this is merged and staging has been merged into 4.0-dev |
I have tested this item ✅ successfully on 5cf5dce
|
I have tested this item ✅ successfully on 5cf5dce This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14924. |
Moved return value out of JS from @C-Lodder 's suggest. That can be more easily to move code to single js file in the future. |
Also moved token out. Maybe we can consider use Laravel way to handle CSRF token for Ajax and JS in J4: https://laravel.com/docs/5.4/csrf#csrf-x-csrf-token |
I have tested this item ✅ successfully on 13630da This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14924. |
1 similar comment
I have tested this item ✅ successfully on 13630da This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14924. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14924. |
yay!!!! |
@asika32764 we have no message of success or error when using drag and drop |
Pull Request for Issue #14905
Summary of Changes
This is a new PR for #14905 that for easy discuss about the new upload layout.
Images
Drag and drop install
Select install
If browser does not support
FormData
, will fallback to original upload layout. Please someone help me test in IE8.