Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_menus] Hide Process button when in Trashed status (Admin menu) #15134

Closed
Quy opened this issue Apr 6, 2017 · 4 comments
Closed

[com_menus] Hide Process button when in Trashed status (Admin menu) #15134

Quy opened this issue Apr 6, 2017 · 4 comments

Comments

@Quy
Copy link
Contributor

Quy commented Apr 6, 2017

Steps to reproduce the issue

Create an Administrator menu.
Create a menu item in this Administrator menu.
Trash this menu item.
Click Search Tools button.
Select Trashed in - Select Status - dropdown.
Select the Administrator menu in - Select Menu - dropdown.
Click Select All checkbox.
Click Batch button.

Expected result

Cancel button only.

Actual result

hide-process-button

@brianteeman
Copy link
Contributor

Confirmed - it is cancel only when on site menus so should be cancel only when on admin menus.

@brianteeman
Copy link
Contributor

@Quy I assume it is this check here that just needs to remove the clientid

<?php if ($published < 0 && $clientId == 1): ?>

brianteeman added a commit to brianteeman/joomla-cms that referenced this issue Oct 2, 2017
PR for joomla#15134

This PR will ensure that the Process button is hidden (I have no idea why you cant batch process trashed items and that is beyond the scope of this PR)

### Steps to reproduce the issue
Create an Administrator menu.
Create a menu item in this Administrator menu.
Trash this menu item.
Click `Search Tools` button.
Select `Trashed` in `- Select Status -` dropdown.
Select the Administrator menu in `- Select Menu -` dropdown.
Click `Select All` checkbox.
Click `Batch` button.

### Expected result
Cancel button only.

### Actual result
![hide-process-button](https://cloud.githubusercontent.com/assets/368084/24762083/24eafaaa-1aa2-11e7-8bc4-188e20869f02.jpg)
@joomla-cms-bot
Copy link

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/15134

@ghost
Copy link

ghost commented Oct 3, 2017

closed as having Pll Request #18195


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15134.

mbabker pushed a commit that referenced this issue Oct 5, 2017
…18195)

* [com_menus] Hide Process button when in Trashed status (Admin menu)

PR for #15134

This PR will ensure that the Process button is hidden (I have no idea why you cant batch process trashed items and that is beyond the scope of this PR)

### Steps to reproduce the issue
Create an Administrator menu.
Create a menu item in this Administrator menu.
Trash this menu item.
Click `Search Tools` button.
Select `Trashed` in `- Select Status -` dropdown.
Select the Administrator menu in `- Select Menu -` dropdown.
Click `Select All` checkbox.
Click `Batch` button.

### Expected result
Cancel button only.

### Actual result
![hide-process-button](https://cloud.githubusercontent.com/assets/368084/24762083/24eafaaa-1aa2-11e7-8bc4-188e20869f02.jpg)

* extra check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants