Fix for issue #15498 #15499
Merged
Fix for issue #15498 #15499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csthomas
reviewed
Apr 24, 2017
| @@ -91,7 +91,7 @@ public function build(&$query, &$segments) | |||
| } | |||
|
|
|||
| // Are we dealing with an article or category that is attached to a menu item? | |||
| if (($menuItem instanceof stdClass) | |||
| if ($menuItem !== null | |||
There was a problem hiding this comment.
Can you add:
&& isset($query['view']) below changed line?
There was a problem hiding this comment.
No - that's not related to this bug - it needs to go in a separate Pull Request
|
I have tested this item ✅ successfully on 87ba5af This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15499. |
2 similar comments
|
I have tested this item ✅ successfully on 87ba5af This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15499. |
|
I have tested this item ✅ successfully on 87ba5af This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15499. |
|
RTC. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15499. |
joomla-cms-bot
added
PR-staging
and removed
RTC
rdeutz
pushed a commit
to joomlajenkins/joomla-cms
that referenced
this pull request
May 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #15498 .
Summary of Changes
It's bad practice to typehint against a stdClass instance. Instead it's better to check we don't get
nullback fromJMenu::getActiveorJMenu::getItemTesting Instructions
Install staging with sample testing data. Go to the featured articles page. Before patch the home page has a url like
JROOT/index.php/19-sample-data-articles/joomla/24-joomla. After the patch it should be JROOT/index.phpDocumentation Changes Required
None