Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #15498 #15499

Merged
merged 1 commit into from
Apr 24, 2017
Merged

Fix for issue #15498 #15499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/com_content/helpers/legacyrouter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public function build(&$query, &$segments)
}

// Are we dealing with an article or category that is attached to a menu item?
if (($menuItem instanceof stdClass)
if ($menuItem !== null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add:
&& isset($query['view']) below changed line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - that's not related to this bug - it needs to go in a separate Pull Request

&& $menuItem->query['view'] == $query['view']
&& isset($query['id'])
&& $menuItem->query['id'] == (int) $query['id'])
Expand Down