Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect calendar paths #15546

Merged
merged 2 commits into from Apr 26, 2017
Merged

Fix incorrect calendar paths #15546

merged 2 commits into from Apr 26, 2017

Conversation

saharin88
Copy link
Contributor

@saharin88 saharin88 commented Apr 25, 2017

Pull Request for Issue #15441 (comment).

Summary of Changes

Fixes incorrect paths for resources

@wilsonge wilsonge changed the title Update behavior.php Fix incorrect calendar paths Apr 25, 2017
@wilsonge
Copy link
Contributor

wilsonge commented Apr 25, 2017

I've fixed the CSS path here and added the link to the correct issue :)

Please can you add testing instructions

@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on 318cec9

To test replace in isis/index.php

defined('_JEXEC') or die;

with

defined('_JEXEC') or die;
JHtml::_('behavior.calendar');

and check the page source for the css and the scripts files


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15546.

@wilsonge
Copy link
Contributor

@brianteeman are you able to test this please?

@zero-24 zero-24 added this to the Joomla 3.7.1 milestone Apr 26, 2017
@brianteeman
Copy link
Contributor

And this is why merging a pr without any tests was a bad idea!!!!

Using the test instructions from @dgt41 this PR works as intended

@wilsonge wilsonge merged commit 84deedf into joomla:staging Apr 26, 2017
@gwsdesk
Copy link

gwsdesk commented Apr 26, 2017

I confirm this as well. This was also posted to me by @markus Bopp of Crosstec just a few ago.This works with the method as described by @dgt41

rdeutz pushed a commit to joomlajenkins/joomla-cms that referenced this pull request May 1, 2017
* Update behavior.php

* Fix CSS path
@saharin88 saharin88 deleted the patch-3 branch May 5, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants