Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the removal of deprecated code #15441

Merged
merged 3 commits into from Apr 23, 2017
Merged

Revert the removal of deprecated code #15441

merged 3 commits into from Apr 23, 2017

Conversation

dgrammatiko
Copy link
Contributor

Pull Request for Issue #15440 .

Summary of Changes

Restore deprecated code, this should be removed in J4 not yet!

Testing Instructions

Review the code!

Expected result

Actual result

Documentation Changes Required

@rdeutz

@rdeutz rdeutz self-assigned this Apr 21, 2017
@rdeutz
Copy link
Contributor

rdeutz commented Apr 21, 2017

could you @avjoomla test if the fix solves the problem

@infograf768
Copy link
Member

Release Blocker?

@rdeutz
Copy link
Contributor

rdeutz commented Apr 21, 2017

@infograf768 we need to test and merge before release

@infograf768
Copy link
Member

Tested that it does not break the new calendar (just to be sure). I do not have a sample code to test the original issue.

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Apr 21, 2017
@wilsonge
Copy link
Contributor

Added release blocker tag

@rdeutz rdeutz merged commit 2f69484 into joomla:staging Apr 23, 2017
@rdeutz rdeutz removed their assignment Apr 23, 2017
@avjoomla
Copy link
Contributor

Just installed a new installation of Joomla! 3.7 as released today.
Sadly there are to typos in the code which was merged into the behavior.php with PR #15441

Line 381 (wrong)
JHtml::('stylesheet', 'system/calendarjos.css', array('version' => 'auto', 'relative' => true), $attribs);
correct:
JHtml::
('stylesheet', 'system/calendar-jos.css', array('version' => 'auto', 'relative' => true), $attribs);

Line 383 (wrong)
JHtml::('script', $tag . '/calendarsetup.js', array('version' => 'auto', 'relative' => true));
correct
JHtml::
('script', $tag . '/calendar-setup.js', array('version' => 'auto', 'relative' => true));

In both cases the file name is incorrect, the minus characters in file names are missing.

Regards,
Aicha


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15441.

@zero-24
Copy link
Member

zero-24 commented Apr 25, 2017

Can you please send that as PR against staging?

rdeutz pushed a commit to joomlajenkins/joomla-cms that referenced this pull request May 1, 2017
* revert

* Update behavior.php

* Update behavior.php

cs fix
@dgrammatiko dgrammatiko deleted the revert-deleted-code branch July 22, 2017 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants