[4.0] Namespace com_categories #15851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianteeman
reviewed
May 6, 2017
| * @param string $prefix The class prefix. Optional. | ||
| * @param array $config The array of possible config values. Optional. | ||
| * | ||
| * @return \Joomla\Cms\Model\Model The model. |
brianteeman
reviewed
May 6, 2017
| @@ -164,14 +170,14 @@ protected function getRedirectToListAppend() | |||
| /** | |||
| * Function that allows child controller access to model data after the data has been saved. | |||
| * | |||
| * @param JModelLegacy $model The data model object. | |||
| * @param array $validData The validated data. | |||
| * @param \Joomla\Cms\Model\Model $model The data model object. | |||
There was a problem hiding this comment.
CMS as before and probably elsewhere
|
@wilsonge were my comments not valid? |
|
They are - but they are also valid in the other PR's I already merged before I got to this one. I'm just about to go do a global search replace :) |
|
i can do it if you want |
|
Sure feel free! |
|
see #15860 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This simple PR convert com_categories component to namespace MVC for Joomla 4.
Testing Instructions
Overall, test to make sure it works in the same as before (none namespace version)
Install latest Joomla 4.0-dev with sample data (or better install my branch https://github.com/joomdonation/joomla-cms/archive/namespace_com_categories.zip)
Login to administrator area of the site, access to Content -> Categories.
Try to add/edit/publish/unpublish/archieve categories, make sure it is working as expected
Additional comment
com_categories require different access permission check compare to most backend component. I ignore the check for now and wait for decision about the method I propose on PR #15812 . If it is accepted, I will implement the check here or on a separate PR.