[4.0] Namespace com_cpanel #15812
Merged
[4.0] Namespace com_cpanel #15812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C-Lodder
reviewed
May 4, 2017
| /** | ||
| * No access permission check needed | ||
| */ | ||
| protected function checkAccess() |
There was a problem hiding this comment.
Does this function need to be here if it's empty?
There was a problem hiding this comment.
Yes. It is needed. Most components in backend need access permission check like this https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/CMS/Dispatcher/Dispatcher.php#L100-L104
However, com_cpanel (and com_login) don't need this check, that's why this method is empty and needed. I mean no access permission check needed for this component.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This simple PR convert cpanel component to namespace MVC in Joomla 4.
Testing Instructions
Additional comments
At the moment, our component dispatcher always check permission for backend component. However, today, I see that some component (like com_cpanel, com_login) doesn't need permission checking, so I move the code which check permission to a separate method to make it easier to for component to override if needed (in this case, no permission check needed, so the method can just be blank). Not sure if it is a right way, I am open for suggestion (just want to bring it for discussion to find the right way)