Fix FinderIndexer::remove() bug where item are never removed. #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…>quote($linkId). It should be casted inside $db->quote() instead.
|
Please open a tracker on joomlacode with test instructions and add link here. |
|
Committed via eclipse. |
laoneo
added a commit
to Digital-Peak/joomla-cms
that referenced
this pull request
Aug 29, 2016
JArrayHelper => ArrayHelper
bembelimen
added a commit
to bembelimen/joomla-cms
that referenced
this pull request
Apr 26, 2018
…_processing Implementing batch processing
wilsonge
pushed a commit
to wilsonge/joomla-cms
that referenced
this pull request
May 26, 2019
richard67
pushed a commit
to richard67/joomla-cms
that referenced
this pull request
Apr 3, 2020
Simple fix adding '!' to Joomla! where it should be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is caused by 2 (int) casts in FinderIndexer::remove() where it is done to $db->quote($linkId).
It should be casted inside $db->quote() instead.