Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] [RFC] Move toolbar apply items to thead #16000

Closed
ciar4n opened this issue May 13, 2017 · 22 comments
Closed

[4.0] [RFC] Move toolbar apply items to thead #16000

ciar4n opened this issue May 13, 2017 · 22 comments

Comments

@ciar4n
Copy link
Contributor

ciar4n commented May 13, 2017

One of a handful of solutions for the toolbar (#12789) is to move the apply items to the table head

toolbar-thead

@brianteeman
Copy link
Contributor

Definitely an interesting option. Should be relatively simple to make accessible as well

@C-Lodder
Copy link
Member

C-Lodder commented May 13, 2017

+1 👍

@brianteeman
Copy link
Contributor

Maybe replace the ... with a cog icon would be more meaningful

@ciar4n
Copy link
Contributor Author

ciar4n commented May 13, 2017

thead-icon1

I guess technically the 3 dots is a menu overflow icon. This would make it correct in the tbody (overflow of the publish and feature icons) but not for the thead icon. Considering this the following would also work..

thead-icon2

@ciar4n
Copy link
Contributor Author

ciar4n commented May 13, 2017

Looks like google opted for 3 vertical dots for a standalone dropdown

icon-google

@tonypartridge
Copy link
Contributor

The three dots are more commonly known, whereas a config icon isn't great since it's a configuration option and publishing it more of a editing option opposed to configuration.

Love the idea though, three dots for me!

@brianteeman
Copy link
Contributor

The problem with the three dots (and why I was suggesting to use something else) is that in J3 we used the three dots as the grab handles for sorting.

@ciar4n
Copy link
Contributor Author

ciar4n commented May 14, 2017

The grab handles in J3 appear to be vertical dots rather than horizontal. Personally I think this should be difference enough not to cause any confusion?

Might make sense to combine this column with the status column. Give a larger clickable area for head dropdown, makes logical sense as this is largely the visible column that is effected and brings the '3 dots' icon inline with the other action icons. Assuming '3 dots' represents overflow options to a menu which is largely the case (eg. https://www.facebook.com/joomla/).

thead-icon3

@brianteeman
Copy link
Contributor

combined columns make the a11y a little harder to maintain but not impossible

@C-Lodder
Copy link
Member

@ciar4n - think it would be much better as separate column. Like you did in the initial screenshot ;)

@brianteeman
Copy link
Contributor

still not sure of the benefit of changing the icon/symbol from the current down arrow to the three dots

@mbabker
Copy link
Contributor

mbabker commented May 14, 2017

IMO the dropdown arrow works in 3.x because it's styled as a group of buttons. Without the button styling, to me it seems more like a misplaced character (just trying to imagine it versus the 3 dots).

@brianteeman
Copy link
Contributor

Something for the UX team?

@C-Lodder
Copy link
Member

who?

@ciar4n
Copy link
Contributor Author

ciar4n commented May 14, 2017

@C-Lodder "Once upon a time in a land far far away ... ... ... "

@ciar4n
Copy link
Contributor Author

ciar4n commented May 14, 2017

Probably not the best example but does show how 3 dots indicate there is more than what is shown which is why this icon is commonly used. Also why it does not work as a standalone icon (table header).

@ciar4n
Copy link
Contributor Author

ciar4n commented May 14, 2017

The clickable area of the head icon (initial screenshot) is very small considering it will probably be used a lot. If giving it a separate column we probably should use text instead...

thead-icon4

@brianteeman
Copy link
Contributor

That works for me :)

@dgrammatiko
Copy link
Contributor

A side note here: the table header titles should be blue (link color) only when there is a clickable title else should be blackish (normal text). In this case e.g. Actions should be black as you shouldn't be able to sort the table depending on the available actions. The same concept should be applied to all the th

@tonypartridge
Copy link
Contributor

tonypartridge commented May 14, 2017 via email

@ciar4n
Copy link
Contributor Author

ciar4n commented May 14, 2017

First of 2 PRs created... #16015

@ciar4n
Copy link
Contributor Author

ciar4n commented May 17, 2017

Second of 2 PRs created.. #16076

@ciar4n ciar4n closed this as completed May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants