Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs unordered list is not semantic #16312

Closed
yaume opened this issue May 29, 2017 · 2 comments
Closed

Breadcrumbs unordered list is not semantic #16312

yaume opened this issue May 29, 2017 · 2 comments

Comments

@yaume
Copy link
Contributor

yaume commented May 29, 2017

the HTML is not semantic. Coding a breadcrumb as an unordered list makes it seem like the items are on the same hierarchical level, like it's a set of items in a row. The items in a breadcrumb are not, they represent a path, with each link being a "child" of the last.
-- Geert van der Heide
According to `Google guides and BreadcrumbList ordered lists seem to be more semantically good

@brianteeman
Copy link
Contributor

I am closing this as we have a pr. If you create a pr you don't need to create an issue at the same time

@yaume
Copy link
Contributor Author

yaume commented May 29, 2017

Sorry about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants