New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] breadcrumbs Changing unordered list to ordered list #16313
Conversation
Un unordered list seems to be semantically wrong an ordered list could be better https://css-tricks.com/markup-for-breadcrumbs/ https://developers.google.com/search/docs/data-types/breadcrumbs http://schema.org/BreadcrumbList
I suspect that this will have to wait until j4 as it potentially will break the layout on an existing site |
It'll wait quite easely as it's not very important and it can be overrided |
updated title |
Seem fine for J4. @yaume - would you mind submitting a PR against the |
I have tested this item ✅ successfully on 2c361e7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16313. |
I have tested this item 🔴 unsuccessfully on 2c361e7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16313. |
Hmm, worked for me in FF. What browser are you using @franz-wohlkoenig ? |
System information4.0.0-dev MAMP 4.1.1
|
I have tested this item ✅ successfully on 2c361e7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16313. |
RTC after two successful tests. |
Are you still having issues with this one franz? |
any feedback on this @franz-wohlkoenig ? |
Once this is merged we can look at making it accessible |
merging than. Thanks for the feedback. Thanks @yaume for your contribution! |
Un unordered list seems to be semantically wrong. An ordered list could be better
Issue #16312
Documentation Changes Required
Google guides
BreadcrumbList