Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] breadcrumbs Changing unordered list to ordered list #16313

Merged
merged 2 commits into from Aug 19, 2017

Conversation

yaume
Copy link
Contributor

@yaume yaume commented May 29, 2017

Un unordered list seems to be semantically wrong. An ordered list could be better

Issue #16312

Documentation Changes Required

Google guides
BreadcrumbList

@brianteeman
Copy link
Contributor

I suspect that this will have to wait until j4 as it potentially will break the layout on an existing site

@yaume
Copy link
Contributor Author

yaume commented May 29, 2017

It'll wait quite easely as it's not very important and it can be overrided

@brianteeman brianteeman changed the title Changing unordered list to ordered list breadcrumbs Changing unordered list to ordered list May 29, 2017
@brianteeman
Copy link
Contributor

updated title

@mbabker mbabker added this to Testing/Review in [4.0] Aurora - Frontend Template Jun 4, 2017
@C-Lodder
Copy link
Member

Seem fine for J4.

@yaume - would you mind submitting a PR against the 4.0-dev branch instead?

@zero-24 zero-24 changed the base branch from staging to 4.0-dev July 19, 2017 18:28
@zero-24
Copy link
Contributor

zero-24 commented Jul 19, 2017

@C-Lodder i have just changed the base branch. So @yaume don't need to do anything ;) Just someone review / test & merge against 4.0

@zero-24 zero-24 added this to the Joomla 4.0 milestone Jul 19, 2017
@C-Lodder
Copy link
Member

I have tested this item ✅ successfully on 2c361e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16313.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 4.0 milestone Jul 20, 2017
@ghost
Copy link

ghost commented Jul 20, 2017

I have tested this item 🔴 unsuccessfully on 2c361e7

please see Screenshot below for Reason of unsuccessfully Test:

bildschirmfoto 2017-07-20 um 16 08 28


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16313.

@C-Lodder
Copy link
Member

Hmm, worked for me in FF. What browser are you using @franz-wohlkoenig ?

@ghost
Copy link

ghost commented Jul 20, 2017

System information

4.0.0-dev
macOS Sierra, 10.12.5
Firefox 54 (64-bit)

MAMP 4.1.1

  • PHP 7.0.15
  • MySQLi 5.6.35

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 2c361e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16313.

@brianteeman brianteeman changed the title breadcrumbs Changing unordered list to ordered list [4.0] breadcrumbs Changing unordered list to ordered list Jul 28, 2017
@ghost
Copy link

ghost commented Jul 29, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 29, 2017
@C-Lodder
Copy link
Member

Are you still having issues with this one franz?

@zero-24
Copy link
Contributor

zero-24 commented Aug 17, 2017

any feedback on this @franz-wohlkoenig ?

@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Aug 17, 2017
@zero-24 zero-24 added this to the Joomla 4.0 milestone Aug 17, 2017
@brianteeman
Copy link
Contributor

Once this is merged we can look at making it accessible

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 17, 2017
@ghost
Copy link

ghost commented Aug 18, 2017

Sorry @zero-24 , missed Question. Will have a Look when #17594 is solved.

@ghost
Copy link

ghost commented Aug 19, 2017

@C-Lodder Answer on your Comment: Issue is solved.

@zero-24
Copy link
Contributor

zero-24 commented Aug 19, 2017

merging than. Thanks for the feedback. Thanks @yaume for your contribution!

@zero-24 zero-24 merged commit 4600082 into joomla:4.0-dev Aug 19, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 19, 2017
@wilsonge wilsonge moved this from Testing/Review to Completed in [4.0] Aurora - Frontend Template Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants