Remove unnecessary condition

[nvyush]

The check !empty($this->item) is unneeded at this point.
It is possible to join the statements of if conditions at the lines 72 and 77.

Pull Request for Issue #16409.

Summary of Changes

Unnecessary condition is removed.
The statements of equivalent conditions is joined.

Testing Instructions

Code review.

Expected result

Actual result

Documentation Changes Required

Not needed.

[Bakual]

Not sure if that is accurate.
Because the first check !empty($this->item->id)is only true when the item already has an id set and other than 0/false (means we edit an existing item).
The second check !empty($this->item) && isset($this->item->id) will be true if the item is valid, but the ID may also be 0 (means it can also be a new item).

[nvyush]

Well, but check !empty($this->item) is not needed and can be removed. If $this->item is empty at this point, all checks $this->item->id above this line will be wrong. Are you agree?
I can update the commit.

[nvyush]

I do not understand, why commit 5ed1d17 is valid, but 6b585ae is not. I simple removed white spaces.

[Bakual]

Imho, the isset should indeed be sufficient, because it will also return false if the item doesn't exist. So we gain nothing by explictiely checking the existence of the item prior to it.

I tried to restart the drone test. looks like an unrelated error to me.

[nvyush]

@Bakual, why continuous-integration/jenkins/pr-merge reported an error? What I must do?

[rdeutz]

@nvyush you can ignore the jenkins failure for now, we are testing a new setup. It is important that the Required checks pass and the drone test (code styles) should also pass.

[nvyush]

@rdeutz, thanks

[Quy]

I have tested this item ✅ successfully on 60788fd

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16412.}

[fancyFranci]

For new items the ID is always NULL. Even by saying a_id=0 in the url. So why not joining the two if-conditions?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16412.}

[Quy]

@FPerisa You're right. They can be combined and remove the second if statement.

[joomla-cms-bot]

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/16412

[Quy]

See PR #20254

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16412.}