Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary condition #16412

Closed
wants to merge 6 commits into from
Closed

Remove unnecessary condition #16412

wants to merge 6 commits into from

Commits on Jun 1, 2017

  1. Remove unnecessary condition 

    The check ```!empty($this->item)``` is unneeded at this point. It is possible to join the statements of if conditions at the lines 72 and 77.
    @nvyush
    nvyush committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    5d75fc4 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary condition

    @nvyush
    nvyush committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    5ed1d17 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary condition

    @nvyush
    nvyush committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    6b585ae View commit details
    Browse the repository at this point in the history

  4. Merge branch 'staging' into patch-1

    @nvyush
    nvyush committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    68f26fe View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2017

  1. Merge branch 'staging' into patch-1

    @nvyush
    nvyush committed Jun 5, 2017
    Configuration menu
    Copy the full SHA
    b9f8d16 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'staging' into patch-1

    @nvyush
    nvyush committed Jun 5, 2017
    Configuration menu
    Copy the full SHA
    60788fd View commit details
    Browse the repository at this point in the history