-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0][RTL][Atum] Add RTL Support #16593
Conversation
For people testing you do not need to install a new language. You may find it easier to test in your own language and you can do this easily For example to change en-GB to RTL you need to edit the administrator/languages/en-GB/en-GB.xml file and change
to
|
I have tested this item 🔴 unsuccessfully on 3514000 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16593. |
Thank you @franz-wohlkoenig. Yes such issues can be reported here and I will amend them the next chance I get. |
@franz-wohlkoenig Alerts and labels now fixed |
@ciar4n thanks, will test more this Weekend. |
@ciar4n: |
@franz-wohlkoenig Btn-group (missing space) has been fixed. Issues also present in LTR I will leave for a separate PR. Maybe just create a issue so we don't forget. |
Fix looks fine. |
Fixed
If I am not mistaken this is correct RTL behaviour The media manager can be ignored for now. I will do the RTL for that separately |
RTL gets very funky when you have LTR text in it - especially punctuation.. Dont worry about that for now it should be fine when using an RTL language and font |
I'm going to merge this as a starting point before it starts accumulating conflicts. I'm sure there's going to be a lot more to do though :) |
Pull Request for Issue # .
Summary of Changes
Broad RTL styling for the Atum backend template.
Testing Instructions
Apply patch and log in to admin with RTL language (eg. Arabic).
Edit: Can also be tested without having to install an RTL language. See.. #16593 (comment)
Expected result
Documentation Changes Required
Screenshots