Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0][RTL][Atum] Add RTL Support #16593

Merged
merged 6 commits into from
Jun 15, 2017
Merged

[4.0][RTL][Atum] Add RTL Support #16593

merged 6 commits into from
Jun 15, 2017

Conversation

ciar4n
Copy link
Contributor

@ciar4n ciar4n commented Jun 9, 2017

Pull Request for Issue # .

Summary of Changes

Broad RTL styling for the Atum backend template.

  • General RTL changes
  • Moved sidebar to right
  • Flipped main navigation
  • Flipped status bar
  • Flipped quick icons
  • Removed directional bootstrap classes
  • Removed floats from table
  • Refactored dashboard modules to allow RTL

Testing Instructions

Apply patch and log in to admin with RTL language (eg. Arabic).

Edit: Can also be tested without having to install an RTL language. See.. #16593 (comment)

Expected result

rtl1

rtl2

rtl3

Documentation Changes Required

Screenshots

@brianteeman
Copy link
Contributor

For people testing you do not need to install a new language. You may find it easier to test in your own language and you can do this easily

For example to change en-GB to RTL you need to edit the administrator/languages/en-GB/en-GB.xml file and change

  <rtl>0</rtl>

to

  <rtl>1</rtl>

@ghost
Copy link

ghost commented Jun 9, 2017

I have tested this item 🔴 unsuccessfully on 3514000

Not sure if:
bildschirmfoto 2017-06-09 um 11 36 46
or
bildschirmfoto 2017-06-09 um 11 37 58
is now to be tested.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16593.

@mbabker mbabker added this to Testing/Review in [4.0] Atum - Backend Template Jun 9, 2017
@ciar4n
Copy link
Contributor Author

ciar4n commented Jun 9, 2017

Thank you @franz-wohlkoenig. Yes such issues can be reported here and I will amend them the next chance I get.

@ciar4n
Copy link
Contributor Author

ciar4n commented Jun 10, 2017

@franz-wohlkoenig Alerts and labels now fixed

@ghost
Copy link

ghost commented Jun 10, 2017

@ciar4n thanks, will test more this Weekend.

@ghost
Copy link

ghost commented Jun 10, 2017

@ciar4n:
This is also in LTR:
bildschirmfoto 2017-06-10 um 08 50 59
missing Space:
bildschirmfoto 2017-06-10 um 08 53 46

@ciar4n
Copy link
Contributor Author

ciar4n commented Jun 11, 2017

@franz-wohlkoenig Btn-group (missing space) has been fixed.

Issues also present in LTR I will leave for a separate PR. Maybe just create a issue so we don't forget.

@ghost
Copy link

ghost commented Jun 11, 2017

Fix looks fine.

#16620

@ghost
Copy link

ghost commented Jun 12, 2017

Text align right:
bildschirmfoto 2017-06-12 um 09 30 25

@ghost
Copy link

ghost commented Jun 12, 2017

Point at Beginning of Sentence?
1
Same Tab, same Question:
bildschirmfoto 2017-06-12 um 09 36 33

@ghost
Copy link

ghost commented Jun 12, 2017

1

@ciar4n
Copy link
Contributor Author

ciar4n commented Jun 13, 2017

Text align right:

Fixed

Point at Beginning of Sentence?

If I am not mistaken this is correct RTL behaviour

The media manager can be ignored for now. I will do the RTL for that separately

@brianteeman
Copy link
Contributor

Point at Beginning of Sentence?
If I am not mistaken this is correct RTL behaviour

RTL gets very funky when you have LTR text in it - especially punctuation.. Dont worry about that for now it should be fine when using an RTL language and font

@wilsonge
Copy link
Contributor

I'm going to merge this as a starting point before it starts accumulating conflicts. I'm sure there's going to be a lot more to do though :)

@wilsonge wilsonge merged commit d2ce0ba into joomla:4.0-dev Jun 15, 2017
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jun 15, 2017
@mbabker mbabker moved this from Testing/Review to Completed in [4.0] Atum - Backend Template Jun 15, 2017
@ciar4n ciar4n deleted the rtl-phase1 branch June 29, 2017 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants