-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the never working limitstart call #17184
Conversation
I have tested this item ✅ successfully on d39631b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17184. |
I have tested this item ✅ successfully on d39631b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17184. |
RTC after two successful tests. |
@mbabker I'm not sure what happend here if you have a few minutes please check this. |
You started the PR based on staging then changed the branch to 3.8. But your staging branch is a few commits ahead of the 3.8 branch (expected, the commits in this PR aren't merged to 3.8 yet). So it's fine for now, I just have to remember to merge staging to 3.8 before merging this PR. |
Thans for checking! |
* staging: (274 commits) Add JCryptCipherSodium to support libsodium (joomla#16754) Performance 2 (libraries/legacy) (joomla#12220) Performance 6 (templates) (joomla#12233) Fixed typehint (joomla#16425) Fix for: Repeatable field is no longer rendered with Chosen layout (joomla#16471) Fix the path for the ajax-loader.gif (joomla#16701) Menu items list parent filter (joomla#17060) Text Filters layout (joomla#17113) mod_login showon option (joomla#17153) com_banners incorret tooltip (joomla#17157) fix joomla.content.options_default (joomla#17123) remove the never working limitstart call (joomla#17184) Update phpDocumentor build set 3.8.0 Dev State Prepare 3.7.4 Stable Release fixed a logic change in joomla#12294, thanks @Hoffi1 Update sv-SE.ini Update pt-BR.ini Update lv-LV.ini Update fa-IR.ini ...
Summary of Changes
Remove the never working limitstart call. I did go back in the history and that not working call is included since the intial commit to GitHub:
https://github.com/joomla/joomla-cms/blame/56fbf2c55293b3188c7d85163dfcf91eac01741c/components/com_content/helpers/icon.php#L106-L110
Intial report by @moira-lachesis
Testing Instructions
Confirm that the print button in the frontend still works.
Expected result
The print button in the frontend still works.
Actual result
The print button in the frontend works but append a empty an unused
&page=
.Documentation Changes Required
None.